Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
- Bump `proguard` from v5.5.0 to v5.6.1
This also bumps the proguard cache version from v3 to v4. ([#1734](https://github.com/getsentry/symbolicator/pull/1734))

### Various fixes & improvements

- Symbolicated JVM frames are now marked according to whether their method was
synthesized by the compiler. ([#1735](https://github.com/getsentry/symbolicator/pull/1735))

## 25.7.0

### Various fixes & improvements
Expand Down
8 changes: 8 additions & 0 deletions crates/symbolicator-proguard/src/interface.rs
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,14 @@ pub struct JvmFrame {
/// instead of using line numbers.
#[serde(skip_serializing_if = "Option::is_none")]
pub signature: Option<String>,

/// Whether this frame's method was synthesized by the compiler.
#[serde(default, skip_serializing_if = "is_false")]
pub method_synthesized: bool,
}

fn is_false(b: &bool) -> bool {
!*b
}

/// An exception in a JVM event.
Expand Down
2 changes: 2 additions & 0 deletions crates/symbolicator-proguard/src/symbolication.rs
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,7 @@ impl ProguardService {
.file()
.map(String::from)
.or_else(|| original_frame.filename.clone()),
method_synthesized: new_frame.method_synthesized(),
..original_frame.clone()
};

Expand Down Expand Up @@ -877,6 +878,7 @@ y.b -> y.b:
abs_path: Some("CustomThreadFactory".into()),
filename: Some("CustomThreadFactory".into()),
index: 0,
method_synthesized: true,
..Default::default()
}
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ stacktraces:
lineno: 0
in_app: true
index: 18
method_synthesized: true
- function: onCreate$lambda-1
module: io.sentry.samples.instrumentation.ui.EditActivity
lineno: 37
Expand Down
Loading