(fix) add pendo as a known outside click#112388
Merged
cobyeastwood183 merged 2 commits intomasterfrom Apr 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Unnecessary
instanceof HTMLElementguard may miss non-HTML elements- Removed the
instanceof HTMLElementnarrowing soclosest('#pendo-guide-container')now runs for allElementtargets, preventing unintended drawer closes on SVG and other non-HTML nodes.
- Removed the
Or push these changes by commenting:
@cursor push ac96c48d23
Preview (ac96c48d23)
diff --git a/static/app/components/events/breadcrumbs/breadcrumbsDataSection.tsx b/static/app/components/events/breadcrumbs/breadcrumbsDataSection.tsx
--- a/static/app/components/events/breadcrumbs/breadcrumbsDataSection.tsx
+++ b/static/app/components/events/breadcrumbs/breadcrumbsDataSection.tsx
@@ -107,10 +107,8 @@
}
// Third-party packages (e.g. Pendo) use a container with id "pendo-guide-container".
// If the click is inside that container, treat it as an internal click.
- if (element instanceof HTMLElement) {
- if (element.closest('#pendo-guide-container')) {
- return false;
- }
+ if (element.closest('#pendo-guide-container')) {
+ return false;
}
return true;
},This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 664e70a. Configure here.
scttcper
reviewed
Apr 7, 2026
scttcper
approved these changes
Apr 7, 2026
…n.tsx Co-authored-by: Scott Cooper <scttcper@gmail.com>
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
<!-- Describe your PR here. --> Third-party packages (e.g. Pendo) aren't considered as outside clicks for the breadcrumb drawer, this adds its container as an additional condition to check. <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Scott Cooper <scttcper@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Third-party packages (e.g. Pendo) aren't considered as outside clicks for the breadcrumb drawer, this adds its container as an additional condition to check.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.