fix(test): stabilize flaky ResultsSearchQueryBuilder spec#111916
Merged
JoshuaKGoldberg merged 5 commits intomasterfrom Apr 14, 2026
Merged
fix(test): stabilize flaky ResultsSearchQueryBuilder spec#111916JoshuaKGoldberg merged 5 commits intomasterfrom
JoshuaKGoldberg merged 5 commits intomasterfrom
Conversation
JoshuaKGoldberg
added
Scope: Frontend
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
changed the base branch from
fix/flaky-test-rerun-infra
to
master
JoshuaKGoldberg
added
Frontend: Rerun Flaky Tests
Stabilize two flaky tests: 1. "does not show function tags in has: dropdown" — timed out at 5000ms because userEvent.type started typing before async API responses (feature flags, recent searches) had settled, causing re-renders mid-typing that slowed each keystroke. Split into click + findByRole (listbox) + keyboard to let initial renders complete before typing. 2. "shows normal tags in the dropdown" — act() warning from SearchQueryBuilderCombobox because pending state updates from API responses fired after test assertions completed. Add waitFor at end to flush pending React state updates before teardown. Also add MockApiClient.clearMockResponses() in beforeEach to prevent mock leakage between tests. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com> Made-with: Cursor
JoshuaKGoldberg
force-pushed
the
fix/flaky-results-search-query-builder-spec-v2
branch
from
4423cc9 to
d919935
Compare
narsaynorath
approved these changes
Apr 14, 2026
JoshuaKGoldberg
deleted the
fix/flaky-results-search-query-builder-spec-v2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies a trio of strategies I've used in other flaky test cleanups:
userEvent.type, switches to callinguserEvent.clickto focus elements,screen.findByRoleto wait until the listbox is populated, and then manually callinguserEvent.keyboardto type. The granular events, each awaited, give more explicit waiting for async operations in-between each.delay:nullforuserEvent.keyboard, to minimize the number of renders triggered by typingcomboboxrole is found, to make sure async setup from the components is done.Fixes ENG-7201
Made with Cursor