fix(test): Fix flaky ResultsSearchQueryBuilder spec

Stabilize two flaky tests:

1. "does not show function tags in has: dropdown" — timed out at 5000ms
   because userEvent.type started typing before async API responses
   (feature flags, recent searches) had settled, causing re-renders
   mid-typing that slowed each keystroke. Split into click + findByRole
   (listbox) + keyboard to let initial renders complete before typing.

2. "shows normal tags in the dropdown" — act() warning from
   SearchQueryBuilderCombobox because pending state updates from API
   responses fired after test assertions completed. Add waitFor at end
   to flush pending React state updates before teardown.

Also add MockApiClient.clearMockResponses() in beforeEach to prevent
mock leakage between tests.

Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
Made-with: Cursor

Author: JoshuaKGoldberg

static/app/views/discover/results/resultsSearchQueryBuilder.spec.tsx

@@ -1,6 +1,12 @@
 import {OrganizationFixture} from 'sentry-fixture/organization';
 
-import {render, screen, userEvent, within} from 'sentry-test/reactTestingLibrary';
+import {
+  render,
+  screen,
+  userEvent,
+  waitFor,
+  within,
+} from 'sentry-test/reactTestingLibrary';
 
 import {SavedSearchType} from 'sentry/types/group';
 import type {Organization} from 'sentry/types/organization';
@@ -11,6 +17,8 @@ import {ResultsSearchQueryBuilder} from './resultsSearchQueryBuilder';
 describe('ResultsSearchQueryBuilder', () => {
   let organization: Organization;
   beforeEach(() => {
+    MockApiClient.clearMockResponses();
+
     organization = OrganizationFixture();
     MockApiClient.addMockResponse({
       url: `/organizations/org-slug/recent-searches/`,
@@ -41,22 +49,24 @@ describe('ResultsSearchQueryBuilder', () => {
           user: {key: 'user', name: 'user', kind: FieldKind.FIELD},
         }}
         recentSearches={SavedSearchType.EVENT}
-        // This fields definition is what caused p50 to appear as a function tag
         fields={[{field: 'p50(transaction.duration)'}]}
       />,
       {
         organization,
       }
     );
 
-    // Focus the input and type "has:p" to simulate a search for p50
     const input = await screen.findByRole('combobox');
-    await userEvent.type(input, 'has:p');
+    await userEvent.click(input);
+    await screen.findByRole('listbox');
+    await userEvent.keyboard('has:p');
 
-    // Check that "p50" (a function tag) is NOT in the dropdown
-    expect(
-      within(screen.getByRole('listbox')).queryByText('p50')
-    ).not.toBeInTheDocument();
+    const listbox = await screen.findByRole('listbox');
+    expect(within(listbox).queryByText('p50')).not.toBeInTheDocument();
+
+    await waitFor(() => {
+      expect(screen.getByRole('combobox')).toBeInTheDocument();
+    });
   });
 
   it.knownFlake('shows normal tags, e.g. transaction, in the dropdown', async () => {
@@ -73,22 +83,26 @@ describe('ResultsSearchQueryBuilder', () => {
           user: {key: 'user', name: 'user', kind: FieldKind.FIELD},
         }}
         recentSearches={SavedSearchType.EVENT}
-        // This fields definition is what caused p50 to appear as a function tag
         fields={[{field: 'p50(transaction.duration)'}]}
       />,
       {
         organization,
       }
     );
 
-    // Check that a normal tag (e.g. "transaction") IS in the dropdown
     const input = await screen.findByRole('combobox');
-    await userEvent.type(input, 'transact');
+    await userEvent.click(input);
+    await screen.findByRole('listbox');
+    await userEvent.keyboard('transact');
 
     expect(
       await within(screen.getByRole('listbox')).findByRole('option', {
         name: 'transaction',
       })
     ).toBeInTheDocument();
+
+    await waitFor(() => {
+      expect(screen.getByRole('combobox')).toBeInTheDocument();
+    });
   });
 });