fix(test): stabilize flaky ResultsSearchQueryBuilder spec (#111916)

Applies a trio of strategies I've used in other flaky test cleanups:

* Instead of broadly typing with `userEvent.type`, switches to calling
`userEvent.click` to focus elements, `screen.findByRole` to wait until
the listbox is populated, and then manually calling `userEvent.keyboard`
to type. The granular events, each awaited, give more explicit waiting
for async operations in-between each.
* `delay:null` for `userEvent.keyboard`, to minimize the number of
renders triggered by typing
* After tests, waiting until the `combobox` role is found, to make sure
async setup from the components is done.

Fixes ENG-7201

Made with [Cursor](https://cursor.com)

---------

Co-authored-by: Claude Sonnet 4 <noreply@anthropic.com>

Author: JoshuaKGoldberg

static/app/views/discover/results/resultsSearchQueryBuilder.spec.tsx

@@ -1,6 +1,12 @@
 import {OrganizationFixture} from 'sentry-fixture/organization';
 
-import {render, screen, userEvent, within} from 'sentry-test/reactTestingLibrary';
+import {
+  render,
+  screen,
+  userEvent,
+  waitFor,
+  within,
+} from 'sentry-test/reactTestingLibrary';
 
 import {SavedSearchType} from 'sentry/types/group';
 import type {Organization} from 'sentry/types/organization';
@@ -51,12 +57,17 @@ describe('ResultsSearchQueryBuilder', () => {
 
     // Focus the input and type "has:p" to simulate a search for p50
     const input = await screen.findByRole('combobox');
-    await userEvent.type(input, 'has:p');
+    await userEvent.click(input);
+    await screen.findByRole('listbox');
+    await userEvent.keyboard('has:p', {delay: null});
 
     // Check that "p50" (a function tag) is NOT in the dropdown
-    expect(
-      within(await screen.findByRole('listbox')).queryByText('p50')
-    ).not.toBeInTheDocument();
+    const listbox = await screen.findByRole('listbox');
+    expect(within(listbox).queryByText('p50')).not.toBeInTheDocument();
+
+    await waitFor(() => {
+      expect(screen.getByRole('combobox')).toBeInTheDocument();
+    });
   });
 
   it.isKnownFlake('shows normal tags, e.g. transaction, in the dropdown', async () => {
@@ -81,14 +92,20 @@ describe('ResultsSearchQueryBuilder', () => {
       }
     );
 
-    // Check that a normal tag (e.g. "transaction") IS in the dropdown
+    // Focus the input and type "transact" to simulate a search for transaction
     const input = await screen.findByRole('combobox');
-    await userEvent.type(input, 'transact');
+    await userEvent.click(input);
+    await screen.findByRole('listbox');
+    await userEvent.keyboard('transact', {delay: null});
 
+    // Check that a normal tag (e.g. "transaction") IS in the dropdown
+    const listbox = await screen.findByRole('listbox');
     expect(
-      await within(screen.getByRole('listbox')).findByRole('option', {
-        name: 'transaction',
-      })
+      await within(listbox).findByRole('option', {name: 'transaction'})
     ).toBeInTheDocument();
+
+    await waitFor(() => {
+      expect(screen.getByRole('combobox')).toBeInTheDocument();
+    });
   });
 });