Merged
Conversation
… favor of test/train split
…ance and compress_data methods to improve HOD handling, add support for line-of-sight directions, and integrate test filters for dataset splitting.
…ess_data methods for improved HOD handling, add support for line-of-sight directions, and integrate test filters for dataset splitting.
SBouchard01
added
enhancement
Closed
There was a problem hiding this comment.
Pull request overview
This PR reworks the BGS observables to enhance functionality with train/test splits, control plots, improved density split classes, and updated compression methods. The changes migrate from the old TwoPointCorrelationFunction API to TwoPointEstimator, refactor the density split correlation implementation into a base class with specific subclasses, and add plotting capabilities.
- Replaces old density split file (
dsc_conf.py) with new modular implementation (density_split_correlation.py) - Adds train/test split support via
test_filtersparameter in compression methods - Introduces
plot_observablemethods for visualization with error bars and residuals - Updates data loading to use
TwoPointEstimatorand new file structure with phase/seed/HOD hierarchy - Enhances
BaseObservableBGSwithget_hod_from_filesmethod for flexible HOD selection
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| acm/observables/bgs/tpcf.py | Updated compression methods with new parameters (phase, seed, los), added train/test splitting, and introduced plot_observable for visualization |
| acm/observables/bgs/dsc_conf.py | Deleted old density split correlation implementation |
| acm/observables/bgs/density_split_correlation.py | New modular implementation with base class and two derived classes for quantile-galaxy and quantile-quantile correlations |
| acm/observables/bgs/base.py | Enhanced with get_hod_from_files for flexible HOD selection, updated emulator methods for train/test compatibility, and improved compress_x logic |
| acm/observables/bgs/init.py | Updated imports to reflect new density split class names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To merge in #118
Reworks the BGS observables, as done in #105 to add the train/test split, control plots, enhance the densitysplit classes and the compression methods.