Open
Conversation
Merged
Collaborator
Author
|
Warning VIDE aliases will need to be implemented after merging #146, I left the current classes names for now Also, I commented out the As mentioned in this comment, the namespace can now be a bit confusing for the files that also match the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds aliases for the Observables classes, as described in #116
Warning
This still needs some works and requires #119 and #118 to be merged in
cosmodesi, as this branch is a child ofcosmodesi-bgs_obs(which is a child ofcosmodesi-emc_obs)If we want to avoid confusion, we need to clarify some naming conventions :
stat_name) of each observable needs to be unique (it's not the case in the VERSUS observables, this is why they don't have aliases yet - @ntbfin00 )In some cases, it makes sense to rename the observables aliases and/or stat_name values (e.g.
pkcould be a bit more clear thanspectrumfor the power spectrum observable ? 🤔);In other cases, we could just rename the file name (e.g.
minkowski.pycould becomeminkowski_functionals.py)This includes:
tpcf,bispectrum,dd_knn,minkowski,projected_tpcf,recon_spectrum,spectrum,wstImportant
This would require to recreate the compressed files !
What needs to be done to have this draft ready for review
stat_namevalue of its observable but this is not mandatory, just less confusing)