Conversation
…od list from raw file list instead of passed number
…in a folder like other mocks formats variables, and have measurement as file names
- Created config.yaml for base box parameters. - Created config_small.yaml for small box parameters. - Added control_plots.ipynb for generating control plots to check Dark Matter catalogs. - Added phases_number.ipynb to determine available phase numbers for small boxes. - Implemented prepare_sim_bgs.sh for batch job submission of base boxes. - Implemented prepare_small_bgs.sh for batch job submission of small boxes. - Added utility functions in utils.py for finding phases and counting files.
…ile for BGS project
…values & DensitySplit control plot
+ update BGS measurements control plots
…l checkpoints in their directory
…et splitting in BGS observables
…ance_y and get_emulator_error to use test/train splits
…liases for classes
…update return type
…y path; refactor compress_x to improve HOD handling and add error checks
|
Regarding the Observables aliases, I'd recommend importing the aliases only in e.g. from acm.observables.emc import tpcf # this is the alias of the GalaxyCorrelationFunctionMultipoles class
from acm.observables.emc.tpcf import GalaxyCorrelationFunctionMultipoles # This is the exact class name
from acm.observables.emc import GalaxyCorrelationFunctionMultipoles # This will crashNote Ideally, we should prevent the files names and the aliases to have the same name to avoid confusion in the namespace 🤔 (e.g. |
|
In an attempt to reduce the review load on this PR, i've created several branches that will include the changes of this branch separately.
Note This should cause a bunch of merge issue in this branch, but I'll solve them. Afterwards, the only remaining changes to UpdateI have successfully reverted most of the changes of the PRs above from this PR, meaning that only remains in this PR the BGS-related changes needed to run the BGS scripts. |
* Revert axm/observables/emc to 31da39e * revert acm/observables/emc/versus.py to 16a594d * Fix from revert * revert acm/observables/emc/versus.py to 3df5c42 * Revert data change * Restore acm/utils/control_plots.py to e468fe1 * Restoring acm/model to a026e53 * restoring acm/observables/bgs/priors to dc3dd8f
|
Once you solve the conflicts feel free to merge |
|
Ready to merge? |
Adding the BGS measurements scripts & Observables, along with some core changes:
get_abacus_phasesmethod to read files from the AbacusSummit mocks and guess the available phasesget_class_from_modulefunction in utils (useful to get all the observables from an ac module ^^)Caution
If it's OK with you @epaillas I will also make a pass on the EMC observables to have a consistent behavior between the two projects after merging the conflicts from #102 (please merge #102 before this PR) - Some suggestions are done in #106