Skip to content

Cosmodesi bgs project update#105

Merged
SBouchard01 merged 88 commits intocosmodesifrom
cosmodesi-bgs
Dec 16, 2025
Merged

Cosmodesi bgs project update#105
SBouchard01 merged 88 commits intocosmodesifrom
cosmodesi-bgs

Conversation

@SBouchard01
Copy link
Collaborator

@SBouchard01 SBouchard01 commented Nov 24, 2025

Adding the BGS measurements scripts & Observables, along with some core changes:

  • Moved the default Observables plots to the base Observable class, as they are quite data-independent
  • Added get_abacus_phases method to read files from the AbacusSummit mocks and guess the available phases
  • Added get_class_from_module function in utils (useful to get all the observables from an ac module ^^)
  • Added plotting utils functions for visualizing parameter space distribution

Caution

If it's OK with you @epaillas I will also make a pass on the EMC observables to have a consistent behavior between the two projects after merging the conflicts from #102 (please merge #102 before this PR) - Some suggestions are done in #106

…od list from raw file list instead of passed number
…in a folder like other mocks formats variables, and have measurement as file names
- Created config.yaml for base box parameters.
- Created config_small.yaml for small box parameters.
- Added control_plots.ipynb for generating control plots to check Dark Matter catalogs.
- Added phases_number.ipynb to determine available phase numbers for small boxes.
- Implemented prepare_sim_bgs.sh for batch job submission of base boxes.
- Implemented prepare_small_bgs.sh for batch job submission of small boxes.
- Added utility functions in utils.py for finding phases and counting files.
@SBouchard01 SBouchard01 mentioned this pull request Dec 5, 2025
@SBouchard01 SBouchard01 linked an issue Dec 5, 2025 that may be closed by this pull request
@SBouchard01
Copy link
Collaborator Author

Regarding the Observables aliases, I'd recommend importing the aliases only in __init__.py, and the full classes names from the files themselves to prevent confusion ? 🤔

e.g.

from acm.observables.emc import tpcf # this is the alias of the GalaxyCorrelationFunctionMultipoles class
from acm.observables.emc.tpcf import GalaxyCorrelationFunctionMultipoles # This is the exact class name
from acm.observables.emc import GalaxyCorrelationFunctionMultipoles # This will crash

Note

Ideally, we should prevent the files names and the aliases to have the same name to avoid confusion in the namespace 🤔 (e.g. acm.observables.tpcf should not include a tpcf alias

@SBouchard01 SBouchard01 removed a link to an issue Dec 6, 2025
@SBouchard01
Copy link
Collaborator Author

SBouchard01 commented Dec 6, 2025

In an attempt to reduce the review load on this PR, i've created several branches that will include the changes of this branch separately.
They should be merged in the following order :

Note

This should cause a bunch of merge issue in this branch, but I'll solve them. Afterwards, the only remaining changes to cosmodesi will be the BGS scripts and some minimal utils functions.

Update

I have successfully reverted most of the changes of the PRs above from this PR, meaning that only remains in this PR the BGS-related changes needed to run the BGS scripts.
Note that the order of review and merging of the PRs above still remains valid, as some of it will impact (and probably overwrite) the content of this PR !

* Revert axm/observables/emc to 31da39e

* revert acm/observables/emc/versus.py to 16a594d

* Fix from revert

* revert acm/observables/emc/versus.py to 3df5c42

* Revert data change

* Restore acm/utils/control_plots.py to e468fe1

* Restoring acm/model to a026e53

* restoring acm/observables/bgs/priors to dc3dd8f
@epaillas
Copy link
Owner

Once you solve the conflicts feel free to merge

@epaillas
Copy link
Owner

Ready to merge?

@SBouchard01 SBouchard01 merged commit 793a496 into cosmodesi Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants