Extend TypeDescription codegen with referenced type inclusion, disable option, raw sources#10
Merged
emersonknapp merged 19 commits intoemersonknapp/type-description-structfrom Apr 5, 2023
Conversation
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
…of date Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
14 tasks
This was referenced Apr 4, 2023
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Owner
Author
emersonknapp
commented
Apr 4, 2023
Owner
Author
There was a problem hiding this comment.
Note for reviewers - these files are the copied generated sources, so they give a good sense for what the templates do, since those are not super easy to read
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
e57ee67 to
f581176
Compare
clalancette
approved these changes
Apr 5, 2023
clalancette
left a comment
There was a problem hiding this comment.
In short, I don't have much to say here; it looks generally good. I'll suggest we go ahead and merge this one into ros2#727 now, and run CI. I'll do one final pass on the combination before approving over there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ros2/ros2#1159
Bundled with (must be merged together):
Replaces (or extends) ros2#727. Key differences
type_support_t->get_type_hash_funcrather than bare valueget_type_descriptionandget_type_sourcestake a typesupport struct argument (for use by dynamic types)Key features:
TYPE_HASH_TUPLESto more accurateTYPE_DESCRIPTION_TUPLESin cmakeget_type_description,get_individual_type_description_source, andget_type_description_sourcesROSIDL_GENERATOR_C_DISABLE_TYPE_DESCRIPTION_CODEGENrosidl_generator_type_descriptionto output a new structure oftype_description_msgplus a flat list of all referenced types and their hashes at the time of generation. These hashes are used at runtime (in Debug builds) to detect ABI breaks when constructing type descriptions the first time