Skip to content

Type Description Typesupport (rep2011)#136

Closed
emersonknapp wants to merge 7 commits intoros2:rollingfrom
emersonknapp:emersonknapp/type-description-support
Closed

Type Description Typesupport (rep2011)#136
emersonknapp wants to merge 7 commits intoros2:rollingfrom
emersonknapp:emersonknapp/type-description-support

Conversation

@emersonknapp
Copy link
Collaborator

@emersonknapp emersonknapp commented Mar 24, 2023

Part of ros2/ros2#1159

Depends on ros2/rosidl#727

Adds type_description and type_description_sources member definitions into _type_support structs.
Note: adds dependency on rosidl_generator_c to do so.

@emersonknapp emersonknapp changed the title Type Description Typesupport (rep2011) [WIP] Type Description Typesupport (rep2011) Mar 24, 2023
@emersonknapp emersonknapp force-pushed the emersonknapp/type-description-support branch 3 times, most recently from ae7031b to 27cf165 Compare March 28, 2023 23:55
@emersonknapp emersonknapp changed the title [WIP] Type Description Typesupport (rep2011) Type Description Typesupport (rep2011) Mar 29, 2023
@emersonknapp emersonknapp marked this pull request as ready for review March 29, 2023 16:23
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp force-pushed the emersonknapp/type-description-support branch from 27cf165 to 216d77a Compare March 29, 2023 17:50
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good.

@emersonknapp
Copy link
Collaborator Author

emersonknapp commented Mar 30, 2023

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@emersonknapp
Copy link
Collaborator Author

emersonknapp commented Apr 4, 2023

Closing in favor of emersonknapp/rosidl#10 bundle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants