Update DeveloperCertificateService to use 'AppHost:Directory' from configuration#13946
Closed
Copilot wants to merge 2 commits intodanegsta/trustfrom
Closed
Update DeveloperCertificateService to use 'AppHost:Directory' from configuration#13946Copilot wants to merge 2 commits intodanegsta/trustfrom
Copilot wants to merge 2 commits intodanegsta/trustfrom
Conversation
Member
|
@copilot restart this work |
…iguration Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
Contributor
Author
Copilot
AI
changed the title
[WIP] Update logging to use 'AppHost:Directory' from configuration
Update DeveloperCertificateService to use 'AppHost:Directory' from configuration
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses feedback from #13943 to update the
DeveloperCertificateServiceto use theAppHost:Directoryconfiguration value instead ofAppHostFilePathfrom options, as the options value may not be populated in all scenarios.Original PR: #13943
Triggering review: #13943 (comment)
Changes Made
DeveloperCertificateService.csto read the AppHost directory directly from configuration usingconfiguration["AppHost:Directory"]instead of usingoptions.AppHostFilePathand callingPath.GetDirectoryName()on itVersionCheckServiceandDistributedApplicationLifecycleaccess the AppHost directoryTesting
The change is minimal and focused, updating only how the AppHost directory path is obtained for the developer certificate trust location error message.
Checklist
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.