Skip to content

Update DeveloperCertificateService to use 'AppHost:Directory' from configuration#13946

Closed
Copilot wants to merge 2 commits intodanegsta/trustfrom
copilot/sub-pr-13943
Closed

Update DeveloperCertificateService to use 'AppHost:Directory' from configuration#13946
Copilot wants to merge 2 commits intodanegsta/trustfrom
copilot/sub-pr-13943

Conversation

Copy link
Contributor

Copilot AI commented Jan 15, 2026

Description

This PR addresses feedback from #13943 to update the DeveloperCertificateService to use the AppHost:Directory configuration value instead of AppHostFilePath from options, as the options value may not be populated in all scenarios.

Original PR: #13943
Triggering review: #13943 (comment)

Changes Made

  • Updated DeveloperCertificateService.cs to read the AppHost directory directly from configuration using configuration["AppHost:Directory"] instead of using options.AppHostFilePath and calling Path.GetDirectoryName() on it
  • This change makes the code consistent with how other services like VersionCheckService and DistributedApplicationLifecycle access the AppHost directory
  • Simplifies the code by removing the need for path manipulation since the configuration already provides the directory directly

Testing

  • ✅ Build succeeded with no errors or warnings
  • ✅ Code review completed with no issues found
  • ✅ Security scan completed with no issues found

The change is minimal and focused, updating only how the AppHost directory path is obtained for the developer certificate trust location error message.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No (existing tests cover this functionality)
  • Did you add public API?
    • Yes
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
    • No

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@danegsta
Copy link
Member

@copilot restart this work

…iguration

Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 15, 2026

@copilot restart this work

I've restarted the work and updated DeveloperCertificateService.cs to use configuration["AppHost:Directory"] instead of options.AppHostFilePath. This makes it consistent with how other services use the AppHost directory. (commit 46b4b59)

Copilot AI changed the title [WIP] Update logging to use 'AppHost:Directory' from configuration Update DeveloperCertificateService to use 'AppHost:Directory' from configuration Jan 15, 2026
@danegsta danegsta closed this Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants