Add logging if we detect the app host is running with an untrusted dev cert#13943
Open
Add logging if we detect the app host is running with an untrusted dev cert#13943
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13943Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13943" |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
danegsta
commented
Jan 15, 2026
10 tasks
Contributor
Member
|
Logging isn't good enough, lets turn this into a notification. |
Member
Author
Added both a notification and explicitly controlling the dev cert the dashboard uses. |
Member
|
/ba-g transient template failures. |
JamesNK
reviewed
Jan 19, 2026
davidfowl
reviewed
Jan 24, 2026
davidfowl
reviewed
Jan 24, 2026
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #21379107285 |
davidfowl
reviewed
Jan 24, 2026
| logger.LogWarning("{Message}", message); | ||
|
|
||
| // Send notification to the dashboard | ||
| _ = interactionService.PromptNotificationAsync( |
Member
Author
There was a problem hiding this comment.
I moved where the check happens to DcpHost alongside the container runtime check.
Contributor
Member
|
@DamianEdwards can you try this out. |
Member
✅ PR #13943 Validation Report - VERIFIEDPR Information
CLI Version Verification
Test Results
EvidenceScenario 2 - Untrusted Certificate:
Scenario 3 - Trusted Certificate:
Overall Result: ✅ PR VERIFIEDThe PR correctly implements:
📋 Full session log: https://gist.github.com/DamianEdwards/9a40bff87fcf4cb6bd37321673feab10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It's possible, particularly after .NET SDK updates, to end up in a situation where there's a newer dev cert added to the
CurrentUser/Mycert store (which is the source of dev certs for TLS termination), but not to theCurrentUser/Rootcert store which is where trusted certificates are pulled from. This can lead to a situation where services try to terminate HTTPS endpoints with an updated dev cert, but nothing actually trusts the new certificate. Diagnosing the issue is confusing and can require checking the logs for individual services.This adds an explicit error level log if automatic dev cert trust is enabled and the latest certificate isn't in the trusted root store.
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate