update Golanci-lint config#1120
update Golanci-lint config#1120openshift-merge-bot[bot] merged 2 commits intocodeready-toolchain:masterfrom
Conversation
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
|
Skipping CI for Draft Pull Request. |
fbm3307
requested review from
MatousJobanek,
alexeykazakov,
jrosental,
metlos,
mfrancisc,
rajivnathan,
ranakan19,
rsoaresd and
xcoulon
as code owners
.golangci.yml
Outdated
| @@ -1,5 +1,5 @@ | |||
| service: | |||
| project-path: github.com/codeready-toolchain/toolchain-e2e | |||
| #service: | |||
There was a problem hiding this comment.
let's just remove these lines, instead of keeping them commented out
There was a problem hiding this comment.
yes we can.. i just didnt know why we had these lines in the first place so just commented it to check and get review
There was a problem hiding this comment.
This is probably some legacy/outdated config and as you pointed out, since v6.5.0, golangci-lint action validates the config and starts failing. We simply didn't realize these lines had been invalid for a long time 🤷♂️
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, MatousJobanek, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e |
openshift-merge-bot
bot
merged commit a87bb8d
into
codeready-toolchain:master
3 participants
The Golanci-lint action recently changed the
golangci-lint verifycommand to by default be true. ChangeThis broke our Golanci-lint CI errorrepo1.
The fix is to remove the additional parameter which the verify doesn't allow
Similar Prs