update Golanci-lint config#626
Merged
jrosental merged 2 commits intocodeready-toolchain:masterfrom Feb 17, 2025
Merged
Conversation
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
fbm3307
requested review from
MatousJobanek,
alexeykazakov,
jrosental,
metlos,
mfrancisc,
rajivnathan,
ranakan19,
rsoaresd and
xcoulon
as code owners
|
This was referenced Feb 17, 2025
Merged
Merged
xcoulon
approved these changes
Feb 17, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #626 +/- ##
=======================================
Coverage 81.64% 81.64%
=======================================
Files 29 29
Lines 3302 3302
=======================================
Hits 2696 2696
Misses 457 457
Partials 149 149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Golanci-lint action recently changed the golangci-lint verify command to by default be true. Change
This broke our Golanci-lint CI errorrepo1.
The fix is to remove the additional parameter which the verify doesn't allow
Similar PRs-