Skip to content

Removing unsupported service#511

Merged
jrosental merged 2 commits intocodeready-toolchain:masterfrom
jrosental:update-golang-config-registration-service
Feb 17, 2025
Merged

Removing unsupported service#511
jrosental merged 2 commits intocodeready-toolchain:masterfrom
jrosental:update-golang-config-registration-service

Conversation

@jrosental
Copy link
Contributor

@jrosental jrosental commented Feb 17, 2025

remove unsupported service:

$ golangci-lint config verify --config=./.golangci.yml jsonschema: "" does not validate with "/additionalProperties": additional properties 'service' not allowed

Similar Prs

@openshift-ci
Copy link

openshift-ci bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrosental, mfrancisc, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [jrosental,mfrancisc,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

@jrosental
Copy link
Contributor Author

/retest-required

@jrosental
Copy link
Contributor Author

/retest

@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.30%. Comparing base (c9e049b) to head (bdfe28c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #511   +/-   ##
=======================================
  Coverage   85.30%   85.30%           
=======================================
  Files          32       32           
  Lines        3109     3109           
=======================================
  Hits         2652     2652           
  Misses        371      371           
  Partials       86       86           
Flag Coverage Δ
unittests 85.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrosental jrosental merged commit e9d68ce into codeready-toolchain:master Feb 17, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants