SANDBOX-1392: Drop dependency on Che instance

[fbm3307]

Description

This PR is to remove the che related unused code

Checks

1. Did you run make generate target? yes

2. Did make generate change anything in other projects (host-operator, member-operator)? yes

3. In case of new CRD, did you the following? NA

   • make/generate.mk in this repository
   • resources/setup/roles/host.yaml in the sandbox-sre repository
   • PROJECT file: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECT
   • CSV file: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yaml

4. In case other projects are changed, please provides PR links.

   • host-operator: SANDBOX-1392: Api pair-Drop dependency on Che instance host-operator#1206
   • member-operator: SANDBOX-1392: API-Pair Drop dependency on Che instance member-operator#704

Summary by CodeRabbit

• Refactor
  • Removed all Che-related public configuration, status fields, types, and related status reasons from the public API surface (including the Che block and dashboard URL); update integrations or configs that referenced them.
• Documentation
  • Deleted public docs, cross-references, and OpenAPI schema entries for Che-related types and removed the cheDashboardURL entry from Routes documentation.

[coderabbitai]

Walkthrough

This change removes Che-related configuration and status fields from the v1alpha1 API, accompanying docs, and generated artifacts: CheConfig, CheSecret, CheStatus, MemberOperatorConfigSpec.che, and Routes.cheDashboardURL are deleted across types, deepcopy, OpenAPI, and docs.

Changes

Cohort / File(s)	Summary of changes
Config API removals api/v1alpha1/memberoperatorconfig_types.go	Deleted Che-related config: removed MemberOperatorConfigSpec.che field, and removed public types CheConfig and CheSecret.
Status API update api/v1alpha1/memberstatus_types.go	Removed Routes.cheDashboardURL field and removed Che / CheStatus from MemberStatusStatus.
Generated code updates api/v1alpha1/zz_generated.deepcopy.go, api/v1alpha1/zz_generated.openapi.go	Removed deepcopy functions and usage for CheConfig/CheSecret/CheStatus; removed OpenAPI schema definitions and references for those types; removed cheDashboardURL from OpenAPI Routes schema and updated dependencies.
Toolchain status constants api/v1alpha1/toolchainstatus_types.go	Removed Che-related member status reason constants (six constants deleted).
Docs cleanup api/v1alpha1/docs/apiref.adoc	Removed CheConfig/CheSecret/CheStatus docs, MemberOperatorConfigSpec.che references, Routes.cheDashboardURL row, and related cross-references.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

• xcoulon
• MatousJobanek
• alexeykazakov

Poem

I nibbled fields of Che away,
A tidy garden, clean today.
No dashboard burrows left to seek,
The schemas trimmed, the docs now sleek.
I hop along, a simpler trail I made. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly summarizes the primary change of removing the Che integration dependency by dropping all Che-related API types and fields, matching the pull request’s main focus and remaining concise and specific.
Description Check	✅ Passed	The pull request description adheres to the repository template by providing a concise goal under the Description heading and fully completing the Checks section with responses and external PR links, including marking the CRD checklist item as not applicable.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2be085a and 82330f2.

📒 Files selected for processing (4)

• api/v1alpha1/docs/apiref.adoc (1 hunks)
• api/v1alpha1/memberstatus_types.go (1 hunks)
• api/v1alpha1/toolchainstatus_types.go (1 hunks)
• api/v1alpha1/zz_generated.openapi.go (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• api/v1alpha1/zz_generated.openapi.go

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Verify Dependencies

🔇 Additional comments (4)

api/v1alpha1/memberstatus_types.go (2)

49-49: LGTM! Comment accurately reflects the removal of Che Dashboard URL.

The comment update correctly reflects that Routes now only contains Console-related information after removing the CheDashboardURL field.

---

49-69: Removed Che-related types and fields fully cleared
Verified no remaining references to CheStatus, CheConfig, CheSecret, CheDashboardURL or .che fields.

api/v1alpha1/docs/apiref.adoc (1)

1184-1184: LGTM! Documentation correctly reflects the removal of Che-related fields.

The documentation update at line 1184 correctly describes Routes as containing only Console-related information, which is consistent with the removal of the CheDashboardURL field from the Routes struct in the Go code.

api/v1alpha1/toolchainstatus_types.go (1)

51-54: Clean removal of Che-related status reason constants
No references to any of the six removed Che-related constants remain; aligns with PR objective to drop Che dependencies.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[alexeykazakov]

I don't believe that the Konflux folks use CheConfig fields in the toolchain config but I wonder if dropping it from CRD can break operator upgrade for them... I don't think so but I'm not 100% sure.
@MatousJobanek WDYT?

[MatousJobanek]

Looks good, but the https://github.com/codeready-toolchain/api/actions/runs/18030938845/job/51306989126?pr=488 workflow failed for other repos as well - can you please open a PR in the other repos with the update of the api dependency to make sure that we won't break anything?

[MatousJobanek]

let's clean up also the comment

api/api/v1alpha1/memberstatus_types.go

Line 49 in 2be085a

// Routes/URLs of the cluster, such as Console and Che Dashboard URLs

and the constants:

api/api/v1alpha1/toolchainstatus_types.go

Lines 55 to 60 in 2be085a

	ToolchainStatusMemberStatusCheRouteUnavailableReason = "CheRouteUnavailable"
	ToolchainStatusMemberStatusCheUserAPICheckFailedReason = "CheUserAPICheckFailed"
	ToolchainStatusMemberStatusCheNotRequiredReason = "CheNotRequired"
	ToolchainStatusMemberStatusCheAdminUserNotConfiguredReason = "CheAdminUserNotConfigured"
	ToolchainStatusMemberStatusCheUserDeletionNotEnabledReason = "CheUserDeletionNotEnabled"
	ToolchainStatusMemberStatusCheReadyReason = "CheReady"

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[fbm3307]

ToolchainStatusMemberStatusCheReadyReason

Thank you for finding this, Have removed it now , PTAL
out of curiosity, what regex did you use to search this or how did you find this, when i tried previously to check if i missed anything i got some 2000 results which were not relevant

[MatousJobanek]

I simply played with the regex to avoid the non-relevant matches:

grep -rine "[^spatn]Che[^c]"