SANDBOX-1392: API-Pair Drop dependency on Che instance#704
SANDBOX-1392: API-Pair Drop dependency on Che instance#704fbm3307 merged 3 commits intocodeready-toolchain:masterfrom
Conversation
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
WalkthroughRemoved Che-related schema fields from two CRDs: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #704 +/- ##
=======================================
Coverage 80.81% 80.81%
=======================================
Files 48 48
Lines 4478 4478
=======================================
Hits 3619 3619
Misses 698 698
Partials 161 161 🚀 New features to boost your workflow:
|
MatousJobanek
left a comment
There was a problem hiding this comment.
the same as in host-operator PR - let's update the go dependency as well
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, fbm3307, MatousJobanek, rajivnathan, rsoaresd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |



This PR is to remove the
cherelated unused code from crdsRelated PRs:
Summary by CodeRabbit