Skip to content

SANDBOX-1392: API-Pair Drop dependency on Che instance#704

Merged
fbm3307 merged 3 commits intocodeready-toolchain:masterfrom
fbm3307:sandbox1392apimember
Oct 8, 2025
Merged

SANDBOX-1392: API-Pair Drop dependency on Che instance#704
fbm3307 merged 3 commits intocodeready-toolchain:masterfrom
fbm3307:sandbox1392apimember

Conversation

@fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Sep 26, 2025

This PR is to remove the che related unused code from crds

Related PRs:

Summary by CodeRabbit

  • Chores
    • Removed Che/CRW configuration from the public configuration schema and removed related status entries, including the Che dashboard URL route.
    • Cleans up deprecated Che exposure in the public API.
    • Breaking change: users and automation referencing these fields should update configurations, scripts, and monitoring accordingly.

Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Sep 26, 2025

Walkthrough

Removed Che-related schema fields from two CRDs: spec.che removed from MemberOperatorConfig; status.che and status.routes.cheDashboardURL removed from MemberStatus. No other openAPIV3Schema sections were modified.

Changes

Cohort / File(s) Summary
CRD schema cleanup (Che removal)
config/crd/bases/toolchain.dev.openshift.com_memberoperatorconfigs.yaml, config/crd/bases/toolchain.dev.openshift.com_memberstatuses.yaml
Deleted the spec.che configuration object from MemberOperatorConfig; removed the status.che section and the status.routes.cheDashboardURL property from MemberStatus openAPIV3Schema. Other schema properties unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • MatousJobanek
  • alexeykazakov
  • rsoaresd
  • jrosental

Poem

A rabbit nibbled YAML fine, 🐇
Removed Che traces, one at a time.
CRDs lighter, routes now neat,
A tidy schema — quick little feat.
Hop, patch, commit — a burrowed treat.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title concisely states that this PR drops the dependency on a Che instance and references the relevant ticket; it clearly matches the removal of Che-related configuration from the CRDs without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e460dd0 and 0bd2af5.

📒 Files selected for processing (1)
  • config/crd/bases/toolchain.dev.openshift.com_memberstatuses.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • config/crd/bases/toolchain.dev.openshift.com_memberstatuses.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build & push operator bundles for e2e tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fbm3307 fbm3307 changed the title SANDBOX-1392: Drop dependency on Che instance SANDBOX-1392: API-Pair Drop dependency on Che instance Sep 26, 2025
@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.81%. Comparing base (52377fd) to head (0bd2af5).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #704   +/-   ##
=======================================
  Coverage   80.81%   80.81%           
=======================================
  Files          48       48           
  Lines        4478     4478           
=======================================
  Hits         3619     3619           
  Misses        698      698           
  Partials      161      161           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same as in host-operator PR - let's update the go dependency as well

Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307 fbm3307 requested a review from MatousJobanek October 6, 2025 14:21
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2025

@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307, MatousJobanek, rajivnathan, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov,fbm3307,rajivnathan,rsoaresd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fbm3307 fbm3307 merged commit 1695608 into codeready-toolchain:master Oct 8, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants