Skip to content

Update API & toolchain-common (to check removal of che config)#554

Merged
fbm3307 merged 3 commits intocodeready-toolchain:masterfrom
fbm3307:updateapitc
Oct 16, 2025
Merged

Update API & toolchain-common (to check removal of che config)#554
fbm3307 merged 3 commits intocodeready-toolchain:masterfrom
fbm3307:updateapitc

Conversation

@fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Oct 6, 2025

The verify dependencies test case was failing for the PR to remove che related code from api and toolchain-common .
This PR is updating the go dependencies for api and toolchain-common to make sure we are not breaking anything before we merge the api and tc PRs

Related PRs:

Similar PRs:

Summary by CodeRabbit

  • Chores
    • Updated underlying dependencies to newer maintained releases to improve stability and compatibility.
    • No changes to public APIs, exported signatures, features, UI, or runtime behavior are expected from this update.
    • Routine maintenance only; no user action required.

Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@openshift-ci openshift-ci bot requested review from jrosental and mfrancisc October 6, 2025 06:39
@openshift-ci openshift-ci bot added the approved label Oct 6, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 6, 2025

Walkthrough

Updates dependency versions in go.mod, bumping two codeready-toolchain require entries to newer pseudo-versions (20251008... and 20251006...). No API or exported signatures were changed.

Changes

Cohort / File(s) Summary of Changes
Dependency management
go.mod
Bumped require entries: github.com/codeready-toolchain/api updated to a v0.0.0-20251008... pseudo-version; github.com/codeready-toolchain/toolchain-common updated to a v0.0.0-20251006... pseudo-version. No other edits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • mfrancisc

Poem

I nudge the go.mod with a twitchy hop,
Two versions hop forward, no build will stop.
Tiny bumps, tidy lines, dependencies hum,
A rabbit's approval—merge when green comes! 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly identifies the core update—bumping the API and toolchain-common modules—and includes context about the che config removal, which aligns with the dependency changes in this pull request.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between effe64f and 54f36ec.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: GolangCI Lint
  • GitHub Check: Test with Coverage
  • GitHub Check: Build & push operator bundles for e2e tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 161b1dc and effe64f.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: ci-check-gomod
go.mod

[error] 1-1: The above replacement(s) are not allowed in go.mod. Process completed with exit code 1.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: GolangCI Lint
  • GitHub Check: Test with Coverage
  • GitHub Check: Build & push operator bundles for e2e tests

@fbm3307
Copy link
Contributor Author

fbm3307 commented Oct 6, 2025

flaky test failure

/test e2e

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.89%. Comparing base (161b1dc) to head (54f36ec).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #554   +/-   ##
=======================================
  Coverage   80.89%   80.89%           
=======================================
  Files          46       46           
  Lines        3564     3564           
=======================================
  Hits         2883     2883           
  Misses        595      595           
  Partials       86       86           
Flag Coverage Δ
unittests 80.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, MatousJobanek, metlos, rajivnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,fbm3307,metlos,rajivnathan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@sonarqubecloud
Copy link

@fbm3307 fbm3307 merged commit a48088a into codeready-toolchain:master Oct 16, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants