Skip to content

Optimize the linear and log convex shape support function #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
jorisv wants to merge 30 commits into
base: devel
Choose a base branch
from
Draft

Optimize the linear and log convex shape support function #758

jorisv wants to merge 30 commits into from

Conversation

@jorisv
Copy link
Contributor

@jorisv jorisv commented Sep 25, 2025 •
edited
Loading

This PR introduce the highway framework

TODO

  • Add linear support function benchmark
  • Optimize highway implementation
  • Add log support function benchmark
  • Find log support function efficient implementation
  • Use SparseSet to improve visited node list clear
  • Look at graph reordering algorithm
  • Replace current implementation by optimized one

Discussion

  • Should highway be an optional dependency: Yes
  • Should we hide highway from the public API: Yes
  • Should we constraint the number of architectures ?

@jorisv jorisv changed the title Optimize the linear and log conex shape support function Optimize the linear and log convex shape support function Sep 25, 2025
@ManifoldFR ManifoldFR self-requested a review September 25, 2025 13:13
ManifoldFR
ManifoldFR reviewed Sep 25, 2025
View reviewed changes
@jorisv jorisv added the pr status wip To not review in weekly meeting label Sep 29, 2025
jorisv added 24 commits October 3, 2025 17:09
@jorisv
bench: Add convex_support.cpp benchmark
1382ed6
@jorisv
ci: Concatenate matrix.cxx_options to CXXFLAGS
7a85d8c
@jorisv
bench: Add highway in convex_support benchmark
b6d7970 
This commit had to wait highway integration in conda-forge: conda-forge/staged-recipes#31092
@jorisv
pixi: Use conda-forge libhwy
7c100e7
@jorisv
bench: Run highway on double scalar type
af9143b
@jorisv
bench: Use ILP to accelerate computation
56c4b52
@jorisv
bench: Fix ILP code and add 4 way test
5468311
@jorisv
bench: Refactor benchmark structure
a6b088b 
- Move icosahedron implementation in a static library
- Add namespace
- Remove dead code
@jorisv
bench: Apply @ManifoldFR review
40cad23
@jorisv
cmake: lint
ddea957
@jorisv
ci: Fix Windows build
4b7da19
@jorisv
bench: Allocate per architecture to pad data structure
17f2523
@jorisv
bench: Construct icosahedron neighbor and remove duplicated points
f0b3349
@jorisv
cmake: Simplify benchmark cmake
8618a90
@jorisv
bench: Store points neighbors in a dedicated class
77bbc3c
@jorisv
bench: Add log support function benchmark
d53af49
@jorisv
bench: Remove SetSupportedTargetsForTest overhead
d41030a
@jorisv
bench: Add WarmStartMesh data structure
9ab22fb
@jorisv
Create algorithms from points instead of Icosahedron
b6508f0
@jorisv
bench: Don't store Icosahedron in IcosahedronWithNeighbors
eaa1ce7
@jorisv
bench: Add supportWithIndex highway implementation
02bbf60
@jorisv
bench: Add first SOA and Cluster algorithm
7e6d5f9
@jorisv
bench: Manage empty cluster and Add Log with Warm Start algorithm
0834100
@jorisv
pixi: Update lock file
0effc90
@jorisv jorisv force-pushed the topic/support-function-bench branch from 3e4e5ca to 0effc90 Compare October 3, 2025 15:12
@jorisv jorisv force-pushed the topic/support-function-bench branch from 64c2c15 to 496eadb Compare October 10, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ManifoldFR ManifoldFR ManifoldFR left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pr status wip To not review in weekly meeting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jorisv @ManifoldFR