Fix Time and BlockNumber used by CeloBackend#484
Merged
karlb merged 2 commits intocelo-rebase-16from Mar 4, 2026
Merged
Conversation
CeloBackend hardcoded both BlockNumber and Time to 0 in the EVM BlockContext, causing the EVM to evaluate chain rules at genesis. With timestamp-activated forks (e.g. Cel2), contracts using post-fork opcodes (like PUSH0) would fail when called through CeloBackend, surfacing as nil fee currency balances. Add BlockNumber and Time fields to CeloBackend and populate them from the appropriate block context at all 9 call sites.
palango
approved these changes
Mar 4, 2026
karlb
added a commit
to celo-org/celo-kona
that referenced
this pull request
Mar 4, 2026
Regression test for celo-org/op-geth#484 where fee currency contract calls used a pre-Shanghai EVM configuration, causing PUSH0 (EIP-3855) to fail. Contracts compiled with Solidity >= 0.8.20 emit PUSH0 by default, so debitGasFees/creditGasFees calls would fail. celo-kona is not affected because the spec is set explicitly via CfgEnv, but this test guards against future regressions using the real Mento StableTokenV2 (USDm) bytecode from Celo mainnet.
karlb
added a commit
to celo-org/celo-kona
that referenced
this pull request
Mar 4, 2026
Regression test for celo-org/op-geth#484 where fee currency contract calls used a pre-Shanghai EVM configuration, causing PUSH0 (EIP-3855) to fail. Contracts compiled with Solidity >= 0.8.20 emit PUSH0 by default, so debitGasFees/creditGasFees calls would fail. celo-kona is not affected because the spec is set explicitly via CfgEnv, but this test guards against future regressions using the real Mento StableTokenV2 (USDm) bytecode from Celo mainnet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/celo-org/celo-blockchain-planning/issues/1357