test(celo-revm): add PUSH0 regression test for fee currency debitGasFees#137
Open
test(celo-revm): add PUSH0 regression test for fee currency debitGasFees#137
Conversation
Regression test for celo-org/op-geth#484 where fee currency contract calls used a pre-Shanghai EVM configuration, causing PUSH0 (EIP-3855) to fail. Contracts compiled with Solidity >= 0.8.20 emit PUSH0 by default, so debitGasFees/creditGasFees calls would fail. celo-kona is not affected because the spec is set explicitly via CfgEnv, but this test guards against future regressions using the real Mento StableTokenV2 (USDm) bytecode from Celo mainnet.
karlb
force-pushed
the
karlb/regression-test-from-geth
branch
from
ac4060c to
3799c13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression test for celo-org/op-geth#484 where fee currency contract calls used a pre-Shanghai EVM configuration, causing PUSH0 (EIP-3855) to fail. Contracts compiled with Solidity >= 0.8.20 emit PUSH0 by default, so debitGasFees/creditGasFees calls would fail.
celo-kona is not affected because the spec is set explicitly via CfgEnv, but this test guards against future regressions using the real Mento StableTokenV2 (USDm) bytecode from Celo mainnet.
I'm not sure how useful this test is, since the problem never happened in celo-kona. So feel free to reject the PR for this reason. It will still live in GitHub to show that celo-kona is unaffected.