Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions arrow-array/src/array/run_array.rs
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,7 @@ mod tests {
use super::*;
use crate::builder::PrimitiveRunBuilder;
use crate::cast::AsArray;
use crate::new_empty_array;
use crate::types::{Int8Type, UInt32Type};
use crate::{Int16Array, Int32Array, StringArray};

Expand Down Expand Up @@ -739,6 +740,26 @@ mod tests {
assert_eq!(run_ends.values(), &run_ends_values);
}

#[test]
fn test_run_array_empty() {
let runs = new_empty_array(&DataType::Int16);
let runs = runs.as_primitive::<Int16Type>();
let values = new_empty_array(&DataType::Int64);
let array = RunArray::try_new(runs, &values).unwrap();

fn assertions(array: &RunArray<Int16Type>) {
assert!(array.is_empty());
assert_eq!(array.get_start_physical_index(), 0);
assert_eq!(array.get_end_physical_index(), 0);
assert!(array.get_physical_indices::<i16>(&[]).unwrap().is_empty());
assert!(array.run_ends().is_empty());
assert_eq!(array.run_ends().sliced_values().count(), 0);
}

assertions(&array);
assertions(&array.slice(0, 0));
}

#[test]
fn test_run_array_fmt_debug() {
let mut builder = PrimitiveRunBuilder::<Int16Type, UInt32Type>::with_capacity(3);
Expand Down
15 changes: 12 additions & 3 deletions arrow-buffer/src/buffer/run.rs
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,18 @@ where
pub fn sliced_values(&self) -> impl Iterator<Item = E> + '_ {
let offset = self.logical_offset;
let len = self.logical_length;
let start = self.get_start_physical_index();
let end = self.get_end_physical_index();
self.run_ends[start..=end].iter().map(move |&val| {

// Doing this roundabout way since the iterator type we return must be
// the same (i.e. cannot use std::iter::empty())
let range = if self.is_empty() {
0..0
} else {
let start = self.get_start_physical_index();
let end = self.get_end_physical_index() + 1;
start..end
};

self.run_ends[range].iter().map(move |&val| {
let val = val.as_usize().saturating_sub(offset).min(len);
E::from_usize(val).unwrap()
})
Expand Down
Loading