fix: avoid panic in RunEndBuffer::sliced_values for empty run arrays#9200
Closed
Jefffrey wants to merge 1 commit intoapache:mainfrom
Closed
fix: avoid panic in RunEndBuffer::sliced_values for empty run arrays#9200Jefffrey wants to merge 1 commit intoapache:mainfrom
RunEndBuffer::sliced_values for empty run arrays#9200Jefffrey wants to merge 1 commit intoapache:mainfrom
Conversation
mhilton
approved these changes
Jan 16, 2026
Contributor
mhilton
left a comment
mhilton
left a comment
There was a problem hiding this comment.
Makes sense to me. I have checked that that test does indeed show a panic without the code change.
Contributor
Author
|
Superseded by #9213 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Reviewing #9182 made me realize we didn't account for empty run arrays in the recent fix for accounting for sliced run arrays in kernels
What changes are included in this PR?
Fix
RunEndBuffer::sliced_valuesto return an empty iterator when the buffer is empty (previously panicked)Also add some tests for empty run arrays
Are these changes tested?
Added tests
Are there any user-facing changes?
No