Refactored pallet RWS v2.0 by akru · Pull Request #381 · airalab/robonomics

akru · 2025-04-01T04:14:01Z

Motivation

Implements #379

Tech improvements

Remove deprecated methods & bug fixes
Switch to non-rotation(static) auction scheme: makes possible millions of parallel auctions

Breaking changes

Two-phase subscription activation: bid and then claim
A lot of renamings & types changes
Storage migration required

* Two phase subscription activation * Subscription beneficiary as parameter * Fix subscription ending bug * Remove Oracle related functions * Remove auction rotation

PaTara43 · 2025-05-05T09:19:23Z

note on manual installation tags update when merging

Copilot

Pull request overview

This PR refactors the Robonomics Web Services (RWS) pallet to implement version 2.0 with significant architectural changes. The refactoring removes deprecated methods, introduces a two-phase subscription activation process (bid then claim), and transitions from a rotation-based auction system to a static auction scheme that supports millions of parallel auctions.

Key changes:

Replaced rotation-based auction system with static auctions using CountedStorageMap
Introduced two-phase subscription activation: bid() to place bids and claim() to activate subscriptions
Changed subscription storage from single map to double map (owner + subscription ID)
Removed oracle-based subscription management and device linking functionality

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.

File	Description
frame/rws/src/lib.rs	Core pallet refactoring: new storage structures, two-phase auction process, removed oracle/device management
frame/rws/src/weights.rs	Updated weight functions to match new extrinsics (removed `set_devices`, `set_oracle`, `set_subscription`; added `claim`)
frame/rws/Cargo.toml	Version bump to 2.0.0 and added missing std feature dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frame/rws/src/lib.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…n lifecycle (#396) * Initial plan * Add comprehensive tests for pallet-robonomics-rws covering auction lifecycle, subscriptions, and fail cases Co-authored-by: akru <786394+akru@users.noreply.github.com> * Fix comment inconsistencies in weight calculation explanations Co-authored-by: akru <786394+akru@users.noreply.github.com> * Remove pallet-robonomics-datalog dependency from tests, use pallet-balances calls instead Co-authored-by: akru <786394+akru@users.noreply.github.com> * Use impl for simple system pallet declaration in tests --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: akru <786394+akru@users.noreply.github.com> Co-authored-by: Alexander Krupenkin <mail@akru.me>

…397) * Initial plan * Add storage migration v1 -> v2 with tests Co-authored-by: akru <786394+akru@users.noreply.github.com> * Fix benchmarking and try-runtime compilation issues Co-authored-by: akru <786394+akru@users.noreply.github.com> * Address code review feedback: improve error handling and batch operations Co-authored-by: akru <786394+akru@users.noreply.github.com> * Addressing PR comments Co-authored-by: akru <786394+akru@users.noreply.github.com> * Use same mock.rs for tests & migration testing in RWS * Fix AuctionDuration in mock.rs to match test expectations (100s) Co-authored-by: akru <786394+akru@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: akru <786394+akru@users.noreply.github.com> Co-authored-by: Alexander Krupenkin <mail@akru.me>

Copilot

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 10 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frame/rws/src/tests.rs

frame/rws/src/lib.rs

frame/subscription/src/lib.rs

frame/rws/src/migrations.rs

frame/rws/src/lib.rs

frame/rws/src/migrations.rs

frame/rws/src/lib.rs

frame/rws/src/benchmarking.rs

frame/rws/src/lib.rs

Copilot · 2025-11-28T14:53:03Z

frame/subscription/src/weights.rs

+    // TODO: run benchmark
+	fn claim() -> Weight {
 		// Proof Size summary in bytes:
 		//  Measured:  `0`
 		//  Estimated: `0`
 		// Minimum execution time: 12_720_000 picoseconds.
 		Weight::from_parts(13_480_000, 0)
 			.saturating_add(T::DbWeight::get().writes(1_u64))


The claim function uses placeholder weight values with a TODO comment to run benchmarks. Before merging to production, these weights should be properly benchmarked to ensure accurate transaction cost estimation.

Suggested change

// TODO: run benchmark

fn claim() -> Weight {

// Proof Size summary in bytes:

// Measured: `0`

// Estimated: `0`

// Minimum execution time: 12_720_000 picoseconds.

Weight::from_parts(13_480_000, 0)

.saturating_add(T::DbWeight::get().writes(1_u64))

/// Storage: `RWS::Auction` (r:1 w:1)

/// Proof: `RWS::Auction` (`max_values`: None, `max_size`: Some(66), added: 2541, mode: `MaxEncodedLen`)

/// Storage: `System::Account` (r:1 w:1)

/// Proof: `System::Account` (`max_values`: None, `max_size`: Some(128), added: 2603, mode: `MaxEncodedLen`)

fn claim() -> Weight {

// Proof Size summary in bytes:

// Measured: `120`

// Estimated: `5144`

// Minimum execution time: 18_500_000 picoseconds.

Weight::from_parts(21_000_000, 5144)

.saturating_add(T::DbWeight::get().reads(2_u64))

.saturating_add(T::DbWeight::get().writes(2_u64))

@dergudzon please run benchmark on referenced hardware and update weights.rs

Copilot · 2025-11-28T14:54:58Z

@akru I've opened a new pull request, #399, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-11-28T15:02:32Z

@akru I've opened a new pull request, #400, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-11-28T15:03:59Z

@akru I've opened a new pull request, #401, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frame/rws/src/migrations.rs

frame/rws/src/lib.rs

frame/subscription/src/lib.rs

frame/rws/src/lib.rs

frame/rws/src/tests.rs

frame/rws/src/lib.rs

scripts/resolc-stub.sh

akru · 2025-12-03T10:03:51Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2025-12-03T10:04:03Z

@akru I've opened a new pull request, #436, to work on those changes. Once the pull request is ready, I'll request review from you.

…migration robustness, and simplify formula (#436)

Copilot

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

frame/rws/src/lib.rs:1

The is_superset implementation for ProxyType has a catch-all _ => false pattern that is unreachable because all enum variants are already covered. This can be simplified or removed to improve code clarity. The pattern match already exhaustively handles: (ProxyType::Any, ), (, ProxyType::Any), and (ProxyType::RwsUser(a), ProxyType::RwsUser(b)).

///////////////////////////////////////////////////////////////////////////////

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

scripts/resolc-stub.sh

runtime/robonomics/src/lib.rs

Copilot · 2025-12-03T12:40:13Z

frame/rws/src/lib.rs

+            // Calculate TPS from amount using the configured ratio (Permill)
+            // The ratio represents μTPS per token stored as parts per million
+            // For example: Permill::from_parts(100) = 100 μTPS per 1 token
+            let amount_u128: u128 = amount.try_into().map_err(|_| Error::<T>::AssetAmountConversionFailed)?;


The error AssetAmountConversionFailed is used when converting AssetBalanceOf<T> to u128 fails. However, this conversion should only fail if AssetBalanceOf<T> is a larger type than u128, which is unlikely given standard Substrate configurations. Consider adding a more specific error message or debug information about what value caused the conversion failure to aid in debugging.

Copilot · 2025-12-03T12:40:13Z

frame/rws/src/lib.rs

+                        // This should never happen as Daily subscriptions always have expiration_time
+                        // This represents a data inconsistency
+                        Err(Error::<T>::InvalidSubscriptionState)?
+                    }


[nitpick] While the comment explains this is a data inconsistency, consider logging this occurrence before returning the error. Data inconsistencies like this could indicate storage corruption or migration issues and should be captured for debugging purposes.

Copilot · 2025-12-03T12:40:13Z

frame/subscription/src/lib.rs

+                    // If there's a winner but no first_bid_time, this represents a data inconsistency
+                    // from migration. Reject further bids to prevent undefined behavior.
+                    return Err(Error::<T>::InvalidAuctionState.into());
+                }


[nitpick] Similar to the previous comment, this data inconsistency check should include logging. This condition specifically mentions migration as a potential cause, making it especially important to track these occurrences for post-migration verification.

…ion (#437) * Initial plan * Add comprehensive documentation for RWS pallet features Co-authored-by: akru <786394+akru@users.noreply.github.com> * Address code review comments - fix formula reference, clarify device accounts, correct storage comment Co-authored-by: akru <786394+akru@users.noreply.github.com> * Improve IoT fleet example with realistic account generation Co-authored-by: akru <786394+akru@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: akru <786394+akru@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

akru · 2025-12-06T16:17:16Z

@copilot run benchmarks for pallet rws and check outputs, atm it fails in some benchmarks.

Copilot · 2025-12-06T16:17:26Z

@akru I've opened a new pull request, #447, to work on those changes. Once the pull request is ready, I'll request review from you.

…mission-based access control (#464) * Initial plan * Rename pallet from rws to rws-auction Co-authored-by: akru <786394+akru@users.noreply.github.com> * Update SubscriptionLedger with transaction tracking fields and v3 migration Co-authored-by: akru <786394+akru@users.noreply.github.com> * Add helper methods for transaction extension support Co-authored-by: akru <786394+akru@users.noreply.github.com> * Simplify pallet - remove migrations, add extension module, use separate storage for tracking Co-authored-by: akru <786394+akru@users.noreply.github.com> * Fix extension compilation issues and export ChargeRwsTransaction Co-authored-by: akru <786394+akru@users.noreply.github.com> * Remove additional storage maps, use free_weight from SubscriptionLedger, deprecate call() extrinsic Co-authored-by: akru <786394+akru@users.noreply.github.com> * Address review feedback: remove call() extrinsic, clean up errors/events, fix runtime integration Co-authored-by: akru <786394+akru@users.noreply.github.com> * Add comprehensive documentation for transaction extension with usage examples Co-authored-by: akru <786394+akru@users.noreply.github.com> * Implement permission-based access control and update extension to accept owner+subscription_id Co-authored-by: akru <786394+akru@users.noreply.github.com> * Address review feedback: remove deprecated event, use StorageMap, add weight benchmarks, update docs, clean up PhantomData Co-authored-by: akru <786394+akru@users.noreply.github.com> * Fix is_superset implementations and correct README documentation about old call() signature Co-authored-by: akru <786394+akru@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: akru <786394+akru@users.noreply.github.com>

* Initial plan * Rename directory and update Cargo.toml files Co-authored-by: akru <786394+akru@users.noreply.github.com> * Update source code references from rws-auction to subscription Co-authored-by: akru <786394+akru@users.noreply.github.com> * Fix workspace dependency and minor code issues Co-authored-by: akru <786394+akru@users.noreply.github.com> * Update remaining documentation references Co-authored-by: akru <786394+akru@users.noreply.github.com> * Fix ProxyType enum in mock to include RwsUser variant Co-authored-by: akru <786394+akru@users.noreply.github.com> * Remove pallet_proxy dependency and proxy functionality Co-authored-by: akru <786394+akru@users.noreply.github.com> * Update frame/subscription/src/tests.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Rename ChargeRwsTransaction to ChargeSubscriptionTransaction and remove old-style call tests Co-authored-by: akru <786394+akru@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: akru <786394+akru@users.noreply.github.com> Co-authored-by: Aleksandr Krupenkin <mail@akru.me> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

… RWS 2.0 (#467) * Initial plan * Add comprehensive subscription usage tests for RWS 2.0 - Add 8 new subscription usage tests covering transaction extension mechanism - Test lifetime subscription weight accumulation over time - Test lifetime subscription with insufficient weight - Test multiple calls with lifetime subscription - Test active daily subscription usage - Test daily subscription expiration scenarios - Test expiration boundary conditions - Test non-existent subscription errors - Test weight calculation accuracy - Fix compilation errors: add Dispatchable bound to SignedExtension - Fix compilation errors: add PartialEq derive to Error enum - Fix mock: add ReserveData type to pallet_assets config - Clean up duplicate test attributes and unused imports Co-authored-by: akru <786394+akru@users.noreply.github.com> * Add benchmarks for grant_access and revoke_access extrinsics - Add grant_access benchmark: creates subscription and grants permission - Add revoke_access benchmark: creates subscription, grants, then revokes permission - All 7 extrinsics now have benchmarks (bid, claim, start_auction, start_lifetime, stop_lifetime, grant_access, revoke_access) - Weights.rs already has placeholder weights for new extrinsics with appropriate storage operation estimates - Note: Actual weight regeneration requires running ./scripts/benchmark-weights.sh on proper hardware Co-authored-by: akru <786394+akru@users.noreply.github.com> * Add comprehensive transaction extension tests and address code review feedback - Add 13 new tests for transaction extension validation and helper methods - Test has_permission: owner and delegate permissions - Test is_subscription_active: lifetime and daily subscription states - Test has_sufficient_weight: weight availability checks - Test validate() method: enabled/disabled, permissions, weight, expiration - Improve code style: clarify import comment, fix line length - Add MILLIS_PER_DAY constant to reduce magic numbers - Improve comments: clarify integer truncation vs rounding - Use lowercase "reference_call_weight" in comments for consistency - Import SignedExtension trait for extension method tests All tests pass: 40 tests (27 original + 13 new) Co-authored-by: akru <786394+akru@users.noreply.github.com> * Update frame/subscription/src/tests.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: akru <786394+akru@users.noreply.github.com> Co-authored-by: Aleksandr Krupenkin <mail@akru.me> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ion (#469) * Initial plan * Migrate ChargeSubscriptionTransaction from SignedExtension to TransactionExtension Co-authored-by: akru <786394+akru@users.noreply.github.com> * Address code review feedback: consolidate test imports Co-authored-by: akru <786394+akru@users.noreply.github.com> * Update frame/subscription/src/extension.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Use post_dispatch_details instead of post_dispatch to handle trait contract correctly Co-authored-by: akru <786394+akru@users.noreply.github.com> * Calculate accurate weight based on actual storage operations in validate_subscription Co-authored-by: akru <786394+akru@users.noreply.github.com> * Update frame/subscription/src/extension.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: akru <786394+akru@users.noreply.github.com> Co-authored-by: Aleksandr Krupenkin <mail@akru.me> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

akru added the enhancement New feature or request label Apr 1, 2025

akru requested review from dkuanyshbaev and ensrationis April 1, 2025 04:14

akru self-assigned this Apr 1, 2025

akru added 2 commits May 4, 2025 08:27

Refactored pallet RWS

4157e39

* Two phase subscription activation * Subscription beneficiary as parameter * Fix subscription ending bug * Remove Oracle related functions * Remove auction rotation

Optimized RWS storage, removed devices functions (use proxy instead)

27a3f43

akru force-pushed the feat/rws2_0 branch from 242c73d to 27a3f43 Compare May 4, 2025 05:28

akru added 2 commits November 28, 2025 15:50

Merge branch 'master' into feat/rws2_0

bfeb42b

Fix compilation

568e6ed

akru requested a review from Copilot November 28, 2025 12:57

Copilot AI reviewed Nov 28, 2025

View reviewed changes

frame/rws/src/lib.rs Outdated Show resolved Hide resolved

frame/rws/src/lib.rs Outdated Show resolved Hide resolved

frame/rws/src/lib.rs Outdated Show resolved Hide resolved

frame/rws/src/lib.rs Outdated Show resolved Hide resolved

frame/rws/src/lib.rs Show resolved Hide resolved

akru marked this pull request as draft November 28, 2025 13:01

Apply Copilot suggestions, fix bugs & typos

9bfc8d9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

This was referenced Nov 28, 2025

Add comprehensive test coverage for pallet-robonomics-rws v2.0 auction lifecycle #396

Merged

Add storage migration v1→v2 for RWS pallet with comprehensive tests #397

Merged

Copilot AI and others added 2 commits November 28, 2025 17:01

akru marked this pull request as ready for review November 28, 2025 14:49

akru requested review from Copilot and dergudzon and removed request for dkuanyshbaev November 28, 2025 14:50

Copilot AI reviewed Nov 28, 2025

View reviewed changes

Copilot AI mentioned this pull request Nov 28, 2025

Rename shadowing variable in RWS benchmark #399

Merged

Copilot AI mentioned this pull request Nov 28, 2025

Fix timestamp inconsistency in test_bid_after_auction_period_ends #400

Merged

Copilot AI mentioned this pull request Nov 28, 2025

Cache expiration_time in SubscriptionLedger to eliminate redundant arithmetic on every call #401

Merged

Apply suggestions from code review

c2296ed

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Dec 3, 2025

View reviewed changes

Copilot AI mentioned this pull request Dec 3, 2025

Address code review feedback: improve error handling, documentation, migration robustness, and simplify formula #436

Merged

10 tasks

Address code review feedback: improve error handling, documentation, …

d79e669

…migration robustness, and simplify formula (#436)

akru requested a review from Copilot December 3, 2025 12:38

Copilot AI reviewed Dec 3, 2025

View reviewed changes

Copilot AI and others added 6 commits December 4, 2025 01:17

Update resolc-stub.sh

3e5b556

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update lib.rs

b97ceca

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'master' into feat/rws2_0

2511e3c

Merge branch 'master' into feat/rws2_0

9d2ebea

Fix runtime build, fix formatting

6afc53a

Copilot AI mentioned this pull request Dec 6, 2025

Fix RWS pallet benchmark compilation and runtime errors #447

Closed

akru changed the base branch from master to release/4.1 January 27, 2026 08:16

Merge branch 'release/4.1' into feat/rws2_0

1df4815

This was referenced Jan 27, 2026

Request for Improvements Subscription Prolongation #377

Closed

Request for improvements Buy Robonomics Subscription for Another account #376

Closed

Copilot AI and others added 9 commits January 27, 2026 12:37

Added RWS 1.6 pallet for backward compatibility

af6a8f2

Fix formatting

c3b6068

Merge branch 'release/4.1' into feat/rws2_0

21cc341

Update deps; fix compilation

6c8ea22

Update Cargo.lock

48fbc4b

Merge branch 'release/4.1' into feat/rws2_0

da9993f

Conversation

akru commented Apr 1, 2025

Uh oh!

PaTara43 commented May 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

akru Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Nov 28, 2025

Uh oh!

Copilot AI commented Nov 28, 2025

Uh oh!

Copilot AI commented Nov 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akru commented Dec 3, 2025

Uh oh!

Copilot AI commented Dec 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

akru commented Dec 6, 2025

Uh oh!

Copilot AI commented Dec 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development