Fix RWS pallet benchmark compilation and runtime errors#447
Closed
Copilot wants to merge 2 commits intofeat/rws2_0from
Closed
Fix RWS pallet benchmark compilation and runtime errors#447Copilot wants to merge 2 commits intofeat/rws2_0from
Copilot wants to merge 2 commits intofeat/rws2_0from
Conversation
- Remove BenchmarkHelper from mock (not needed for pallet-assets) - Fix benchmark test suite to reference mock module correctly - Use larger timestamp in mock for benchmarks to avoid time-related issues - Fix claim benchmark to properly handle auction time requirements - Remove unused imports from benchmarking.rs Co-authored-by: akru <786394+akru@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor Robonomics Web Services pallet to v2.0
Fix RWS pallet benchmark compilation and runtime errors
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RWS pallet benchmarks failed to compile due to incorrect mock configuration and test suite references. Additionally, the
claimbenchmark failed at runtime due to time validation constraints.Changes:
BenchmarkHelpertype assignment from pallet-assets config (not part of the trait interface)impl_benchmark_test_suite!to referencecrate::mock::Testinstead of non-existentcrate::tests::Runtimefirst_bid_timeto past value via direct storage manipulation, ensuringfirst_bid_time + AuctionDuration <= nowcondition is metAll 5 benchmarks (start_auction, bid, claim, start_lifetime, stop_lifetime) now compile and execute successfully.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.