Cache expiration_time in SubscriptionLedger to eliminate redundant arithmetic on every call#401
Merged
akru merged 4 commits intofeat/rws2_0from Nov 28, 2025
Merged
Conversation
…ization Co-authored-by: akru <786394+akru@users.noreply.github.com>
…lity Co-authored-by: akru <786394+akru@users.noreply.github.com>
Co-authored-by: akru <786394+akru@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add expiration_time field to RWS pallet refactor
Cache expiration_time in SubscriptionLedger to eliminate redundant arithmetic on every call
Nov 28, 2025
Copilot stopped work on behalf of
akru due to an error
November 28, 2025 15:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses performance feedback from #381 (#381 (comment)). For Daily subscriptions,
subscription.issue_time + duration_mswas computed on everycall()invocation.Changes
Added
expiration_time: Option<Moment>field toSubscriptionLedgerSome(issue_time + days * DAYS_TO_MS)for Daily subscriptionsNonefor Lifetime subscriptionsUpdated
call()to use cached value instead of recalculating expiration on each invocationExtended v1→v2 migration to compute and populate
expiration_timefor existing Daily subscriptionsAll 27 tests pass.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.