Merged
Conversation
8c57d8a to
3c4d218
Compare
Collaborator
|
The |
07563e0 to
bf7beda
Compare
Collaborator
|
Fix the empty if block on line 983, add ReservedName to the error mapper and wire up fslock for registry file ops |
dbc76ec to
d5f694d
Compare
Collaborator
|
rebase to fix label |
7dd9666 to
f7ee15a
Compare
1 task
22d5a0e to
03576c1
Compare
Signed-off-by: arse09 <arse.dc.09@gmail.com>
- Revert log::error! to eprintln! for pre-exit messages (fires before logger is initialized) - Add MAX_COPY_DEPTH (16) to copy_dir to prevent stack overflow from symlink loops or deeply nested directories during duplication
0795804 to
2673ae5
Compare
27d49e3 to
54aaf16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Big PR baby
Summary
lib/helpers.ts.Folder structure
.pomme/ ├── assets/ │ ├── indexes/ # indexes_dir │ └── objects/ # objects_dir ├── pomme-assets/ # pomc_assets_dir ├── versions/ │ └── 26.1/ │ ├── 26.1.jar │ ├── 26.1.json │ └── extracted/ │ └── assets/ # jar_assets_dir │ └── minecraft/ │ ├── blockstates/ │ ├── models/ │ └── textures/ │ ├── installations.json └── installations/ ├── default └── <installation>/ <installation>/ # game_dir ├── saves/ ├── mods/ ├── resourcepacks/ ├── shaderpacks/ ├── screenshots/ ├── logs/ ├── options.json ├── servers.json └── icon.png