Skip to content

feat: Implement installations#62

Merged
Purdze merged 39 commits intoPommeMC:masterfrom
arse09:feat/installations
Apr 6, 2026
Merged

feat: Implement installations#62
Purdze merged 39 commits intoPommeMC:masterfrom
arse09:feat/installations

Conversation

@arse09
Copy link
Copy Markdown
Contributor

@arse09 arse09 commented Mar 24, 2026

Big PR baby

Summary

  • New lib/helpers.ts.
  • Save installations to disk.
  • Load installations from disk.
  • Duplicate installations.
  • Edit & save installations.
  • "Latest release" & "Latest snapshot" installations.
  • Allow users to choose their own path for installations.

Folder structure

.pomme/
├── assets/
│   ├── indexes/                        # indexes_dir
│   └── objects/                        # objects_dir
├── pomme-assets/                        # pomc_assets_dir
├── versions/
│   └── 26.1/
│       ├── 26.1.jar
│       ├── 26.1.json
│       └── extracted/
│           └── assets/                 # jar_assets_dir
│               └── minecraft/
│                   ├── blockstates/
│                   ├── models/
│                   └── textures/
│
├── installations.json
└── installations/
    ├── default
    └── <installation>/

<installation>/                         # game_dir
    ├── saves/
    ├── mods/
    ├── resourcepacks/
    ├── shaderpacks/
    ├── screenshots/
    ├── logs/
    ├── options.json
    ├── servers.json
    └── icon.png

@arse09 arse09 mentioned this pull request Mar 24, 2026
5 tasks
@arse09 arse09 force-pushed the feat/installations branch from 8c57d8a to 3c4d218 Compare March 25, 2026 15:26
@arse09 arse09 marked this pull request as ready for review March 25, 2026 15:43
@arse09 arse09 closed this Mar 25, 2026
@arse09 arse09 reopened this Mar 25, 2026
@arse09 arse09 marked this pull request as draft March 25, 2026 15:44
@Purdze
Copy link
Copy Markdown
Collaborator

Purdze commented Mar 25, 2026

The setInstallations error is from #68 which merged to master after your branch was created. Please rebase onto master to resolve:

git fetch origin
git rebase origin/master

@arse09 arse09 force-pushed the feat/installations branch 2 times, most recently from 07563e0 to bf7beda Compare March 26, 2026 02:26
@Purdze
Copy link
Copy Markdown
Collaborator

Purdze commented Mar 26, 2026

Fix the empty if block on line 983, add ReservedName to the error mapper and wire up fslock for registry file ops

@Purdze Purdze added the launcher Launcher application changes label Mar 27, 2026
@arse09 arse09 force-pushed the feat/installations branch 3 times, most recently from dbc76ec to d5f694d Compare March 28, 2026 10:59
@Purdze
Copy link
Copy Markdown
Collaborator

Purdze commented Mar 28, 2026

rebase to fix label

@Purdze Purdze added the patch Bumps patch version (0.0.x) label Mar 28, 2026
@arse09 arse09 force-pushed the feat/installations branch 3 times, most recently from 7dd9666 to f7ee15a Compare March 29, 2026 00:37
@arse09 arse09 force-pushed the feat/installations branch from 22d5a0e to 03576c1 Compare April 1, 2026 01:56
@arse09 arse09 changed the title feat(installations): Implement installations feat: Implement installations Apr 1, 2026
arse09 and others added 21 commits April 4, 2026 00:23
- Revert log::error! to eprintln! for pre-exit messages (fires before
  logger is initialized)
- Add MAX_COPY_DEPTH (16) to copy_dir to prevent stack overflow from
  symlink loops or deeply nested directories during duplication
@Purdze Purdze force-pushed the feat/installations branch from 0795804 to 2673ae5 Compare April 3, 2026 23:45
@arse09 arse09 force-pushed the feat/installations branch from 27d49e3 to 54aaf16 Compare April 5, 2026 14:32
@arse09 arse09 marked this pull request as ready for review April 5, 2026 15:59
Copy link
Copy Markdown
Collaborator

@Purdze Purdze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging

@Purdze Purdze merged commit cfd5e95 into PommeMC:master Apr 6, 2026
6 checks passed
@arse09 arse09 deleted the feat/installations branch April 6, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

launcher Launcher application changes patch Bumps patch version (0.0.x)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants