refactor(client-fs): asset storage and path handling#106
Merged
Purdze merged 4 commits intoPommeMC:masterfrom Mar 31, 2026
Merged
refactor(client-fs): asset storage and path handling#106Purdze merged 4 commits intoPommeMC:masterfrom
Purdze merged 4 commits intoPommeMC:masterfrom
Conversation
Collaborator
|
Version is now a required arg, cargo run without --version will fail. Consider keeping it Option with a fallback or document that dev mode needs --version for_each_blockstate dropped asset_index, blockstates now only resolve from jar_assets_dir. This is fine if blockstates are always in the extracted jar, but worth confirming no edge case uses the asset index for blockstate lookup Might be worth checking settings.json doesnt collide with other settings |
Contributor
Author
|
Block-states are always in the JAR, never in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is meant for updating the current asset and installation directory layout to prepare for #62.
Summary
data.rsnow isdirs.rsand it stores the paths for the directories that the client usesassets_dirvariable withjar_assets_dir,objects_dirandindexes_dir. Also addedpomc_assets_dirto store all custom non vanilla data.DataDirsstruct stored in theApp:.pomc/ ├── assets/ │ ├── indexes/ # indexes_dir │ └── objects/ # objects_dir ├── pomc-assets/ # pomc_assets_dir ├── versions/ │ └── 26.1/ │ ├── 26.1.jar │ ├── 26.1.json │ └── extracted/ │ └── assets/ # jar_assets_dir │ └── minecraft/ │ ├── blockstates/ │ ├── models/ │ └── textures/ │ ├── installations.json └── installations/ <installation>/ # game_dir ├── saves/ ├── mods/ ├── resourcepacks/ ├── shaderpacks/ ├── screenshots/ ├── logs/ ├── options.json ├── servers.json └── icon.pngTest plan