Merged
Conversation
f4d1100 to
9030abe
Compare
9030abe to
5731230
Compare
f99bdb1 to
ab8bab4
Compare
Purdze
requested changes
Mar 24, 2026
Collaborator
Purdze
left a comment
There was a problem hiding this comment.
data_dir() called repeatedly, every path function calls data_dir() which calls ProjectDirs::from() each time. Should cache it with LazyLock or OnceLock
Settings loaded from disk on every toggle, update_settings calls load() then save() on each click. Should keep settings in memory and only write on change
accounts.json is fine for non-sensitive data (username, UUID) but auth tokens should stay in the OS keyring where they're encrypted. Don't migrate tokens to a plaintext JSON file
Purdze
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a refactor of storage handling and separating filesystem logic from downloader logic.
Summary
src/storage.rs.settings.json.-
accounts.json: Accounts data like username and UUID. Future pr.-
installations.json: UI data of each installation for quick loading. PR: feat: Implement installations #62-
installations/: Each installation's directory. PR: feat: Implement installations #62-
settings.json: Launcher settings.- Probably
servers.jsonbut idk: Issue: Implement Servers page in launcher #45Test plan
.pomcfolder from your projects directory.- Linux:
$XDG_DATA_HOME/.pomc(usually~/.local/share/.pomc)- Windows:
%APPDATA%\.pomc(usuallyC:\Users\<User>\AppData\Roaming\.pomc)- macOS:
$HOME/Library/Application Support/.pomc