Draft
Conversation
kaljarv
requested changes
Apr 28, 2025
Contributor
kaljarv
left a comment
kaljarv
left a comment
There was a problem hiding this comment.
Can you add settings to packages/app-shared/src/settings/staticSettings.ts for enabling Sentry (not enabled by default) and configuring the sourceMapsUploadOptions (for Sveltekit). We'll still be needing the envs for any secrets, tho.
It'd be great if also the imports from sentry as well as any Sentry.inits and plugin loads for Strapi and Sveltkit would be conditional on this setting.
gogarufi
reviewed
Jun 1, 2025
|
|
||
| // If you have a custom error handler, pass it to `handleErrorWithSentry` | ||
| export const handleError = handleErrorWithSentry(); | ||
| // Note, since optionalHandleErrorWithSentry is assigned in a promise, |
Collaborator
There was a problem hiding this comment.
This might be a dealbreaker for conditional importing? :)
gogarufi
reviewed
Jun 1, 2025
| @@ -1,4 +1,5 @@ | |||
| import * as Sentry from '@sentry/sveltekit'; | |||
Collaborator
There was a problem hiding this comment.
I don't think that on the server side we benefit from conditional dynamic importing of Sentry.
11 tasks
Contributor
Author
|
Just created #778 in case if it's still needed. |
kaljarv
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY:
Fixes #533
What has been changed (if possible, add screenshots, gifs, etc. )
BACKEND_SENTRY_DSN) and one for the frontend (SvelteKit,PUBLIC_FRONTEND_SENTRY_DSN).'global::error-capture'middleware.hooks.client.jsandhooks.server.js.Testing:
There are some errors in Sentry :)
TODO:
Check off each of the following tasks as they are completed