-
Notifications
You must be signed in to change notification settings - Fork 2
⏳ Feat: Report errors to Sentry #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
shmeleva
wants to merge
4
commits into
main
Choose a base branch
from
feat/send-errors-to-sentry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import type { Core } from '@strapi/strapi'; | ||
| import type { Context, Next } from 'koa'; | ||
|
|
||
| export default (_config: Record<string, unknown>, { strapi }: { strapi: Core.Strapi }) => { | ||
| return async (_ctx: Context, next: Next) => { | ||
| try { | ||
| await next(); | ||
| } catch (error) { | ||
| strapi.plugin('sentry').service('sentry').sendError(error); | ||
| throw error; | ||
| } | ||
| }; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { staticSettings } from '@openvaa/app-shared'; | ||
| import { constants } from '$lib/utils/constants'; | ||
|
|
||
| let optionalHandleErrorWithSentry = () => {}; | ||
|
|
||
| if (staticSettings.analytics.sentryErrorReporting) { | ||
| import('@sentry/sveltekit').then(Sentry => { | ||
| Sentry.init({ | ||
| dsn: constants.PUBLIC_FRONTEND_SENTRY_DSN, | ||
|
|
||
| tracesSampleRate: 1.0, | ||
|
|
||
| // This sets the sample rate to be 10%. You may want this to be 100% while | ||
| // in development and sample at a lower rate in production | ||
| replaysSessionSampleRate: 0.1, | ||
|
|
||
| // If the entire session is not sampled, use the below sample rate to sample | ||
| // sessions when an error occurs. | ||
| replaysOnErrorSampleRate: 1.0, | ||
|
|
||
| // If you don't want to use Session Replay, just remove the line below: | ||
| integrations: [Sentry.replayIntegration()] | ||
| }); | ||
|
|
||
| optionalHandleErrorWithSentry = Sentry.handleErrorWithSentry() | ||
| }); | ||
| } | ||
|
|
||
| // If you have a custom error handler, pass it to `handleErrorWithSentry` | ||
| // Note, since optionalHandleErrorWithSentry is assigned in a promise, | ||
| // there might be a runtime delay before Sentry handler is used to handle errors. | ||
| export const handleError = optionalHandleErrorWithSentry; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,29 @@ | ||
| import * as Sentry from '@sentry/sveltekit'; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think that on the server side we benefit from conditional dynamic importing of Sentry. |
||
| import { staticSettings } from '@openvaa/app-shared'; | ||
| import { sequence } from '@sveltejs/kit/hooks'; | ||
| import { API_ROOT } from '$lib/api/adapters/apiRoute/apiRoutes'; | ||
| import { defaultLocale, loadTranslations, locales } from '$lib/i18n'; | ||
| import { matchLocale, parseAcceptedLanguages } from '$lib/i18n/utils'; | ||
| import { constants } from '$lib/utils/constants'; | ||
| import { logDebugError } from '$lib/utils/logger'; | ||
| import type { Handle, HandleServerError } from '@sveltejs/kit'; | ||
|
|
||
| if (staticSettings.analytics.sentryErrorReporting) { | ||
| Sentry.init({ | ||
| dsn: constants.PUBLIC_FRONTEND_SENTRY_DSN, | ||
| tracesSampleRate: 1 | ||
| }); | ||
| } | ||
| // Handle and handleError based on sveltekit-i18n examples: https://github.com/sveltekit-i18n/lib/blob/master/examples/locale-router-advanced/src/hooks.server.js | ||
|
|
||
| /** Set to `true` to show debug log in console */ | ||
| const DEBUG = false; | ||
|
|
||
| export const handle: Handle = (async ({ event, resolve }) => { | ||
| const optionalSetryHandle: Handle = staticSettings.analytics.sentryErrorReporting ? Sentry.sentryHandle() : ({ event, resolve }) => { | ||
| return resolve(event); | ||
| }; | ||
|
|
||
| export const handle: Handle = sequence(optionalSetryHandle, (async ({ event, resolve }) => { | ||
| const { params, route, url, request, isDataRequest } = event; | ||
| const { pathname, search } = url; | ||
| const requestedLocale = params.lang; | ||
|
|
@@ -111,17 +125,17 @@ export const handle: Handle = (async ({ event, resolve }) => { | |
| transformPageChunk: ({ html }) => html.replace('%lang%', `${servedLocale}`) | ||
| } | ||
| ); | ||
| }) satisfies Handle; | ||
| }) satisfies Handle); | ||
|
|
||
| export const handleError = (async ({ error, event }) => { | ||
| export const handleError = staticSettings.analytics.sentryErrorReporting ? Sentry.handleErrorWithSentry((async ({ error, event }) => { | ||
| const { locals } = event; | ||
| const currentLocale = locals?.currentLocale; | ||
| logDebugError('handleError', error); | ||
| if (currentLocale) await loadTranslations(currentLocale, 'error'); | ||
| return { | ||
| message: '500' | ||
| }; | ||
| }) satisfies HandleServerError; | ||
| }) satisfies HandleServerError) : () => {}; | ||
|
|
||
| /** Show debug message if `DEBUG` is `true` */ | ||
| function debug(message: unknown, error?: unknown) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a dealbreaker for conditional importing? :)