-
Notifications
You must be signed in to change notification settings - Fork 21
tweak env/reqs to utilize latest version(s) of PCMDI/cmor
#707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…s the libnetcdf req too hard
PCMDI/cmor
|
currently failing? oui, but given that environment creation for |
… cmor3.14 specifically (the latest)
|
apparently, using |
…ith the environment yaml
…and backend tools to try and address conda package build error
…add assert where it was missing and add a doc string here or there, clean up some commented out code, add some more helpful assert-failure statements
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #707 +/- ##
==========================================
- Coverage 85.35% 82.85% -2.50%
==========================================
Files 68 68
Lines 4520 4520
==========================================
- Hits 3858 3745 -113
- Misses 662 775 +113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Note that this includes changes that are breaking for |
Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…#712) * Initial plan * Add comprehensive documentation for PR #707 dependency changes Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com> * Update regrid_xy README: Python >=3.11, fregrid no longer bundled Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com> * Add optional fre-nctools loading instructions to setup sections Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com> * Revise fre-nctools loading instructions in README Updated instructions for loading fre-nctools and added notes on installation options. * Add optional fre-nctools loading instructions to docs/ setup sections Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Describe your changes
>=3.11, we currently seem to be comfortably landing on3.12cmorversion is now3.14or greaternoaa-gfdl::fre-nctoolsremoved from all requirements, tests requiring it now check for the appropriate executables usingshutil.whichpython,pip,setuptoolsandwheelall needed to be specified inrequirements: build:formeta.yamlto avoid a build issue on more recentpython/condaversions that we are now starting to develop compatibility forassertchecks were added and/or tweaked to be more helpfulIssue ticket number and link (if applicable)
see
Developmenttab on the right side of this PR screenChecklist before requesting a review
[ ] I wrote a new test, if applicable