-
Notifications
You must be signed in to change notification settings - Fork 21
Document PR #707 dependency changes: Python >=3.11, fregrid unbundled #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document PR #707 dependency changes: Python >=3.11, fregrid unbundled #712
Conversation
Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
|
@copilot too wordy, very much overkill. do these steps in order-
do not add new sections nor files unless absolutely necessary. favor adjusting the current language in the doc instead of adding completely new language. |
Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Reverted all changes and made minimal surgical edit. Only updated fre/app/regrid_xy/README.md line 5:
Commit: efe3b6d |
|
@copilot ok now find specific sections with set-up instructions, and add a step with a comment in the direction of, "# optional, load fre-nctools into your PATH to gain access to regridding and certain time-averaging routines.". Keep being surgical and minimal with edits |
Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Added optional fre-nctools loading instructions to all setup sections:
Each includes commented instruction about loading fre-nctools for regridding/time-averaging routines. Commit: cb96f5c |
Updated instructions for loading fre-nctools and added notes on installation options.
|
@copilot now do what you just did, but dig into the files under |
Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Added optional fre-nctools loading instructions to docs/ setup sections:
Each includes commented instruction about loading fre-nctools for regridding/time-averaging routines. Commit: 55aec31 |
Describe your changes
Minimal documentation updates for PR #707 dependency changes. Updates outdated information and adds optional setup instructions for fre-nctools across all documentation files.
Changes Made
fre/app/regrid_xy/README.md: Updated line 5 to reflect:
3.9.16to>= 3.11(tested/developed with Python 3.12)fre-nctoolsno longer bundled as package dependency; must be loaded externally viamodule load fre-nctoolsmetomitoxarrayto match actual dependenciesREADME.md: Added optional fre-nctools loading instructions to setup sections:
CONTRIBUTING.md: Added optional step for developers to load fre-nctools for regridding and time-averaging routines (line 6)
docs/setup.rst: Added optional fre-nctools loading instruction after
pip install -e .in the development setup sectiondocs/contributing_to_doc.rst: Added optional fre-nctools loading instruction after
conda activate fre-cliin the full environment approach sectionAll changes are surgical edits to existing documentation, avoiding addition of new sections or files. Instructions for fre-nctools are presented as optional commented steps to guide users without being intrusive.
Issue ticket number and link (if applicable)
Related to PR #707 dependency changes
Checklist before requesting a review
Original prompt
Overview
PR #707 introduces significant dependency changes that require documentation updates. This PR adds comprehensive documentation to reflect these changes.
Changes Made in PR #707
3.11.*to>=3.11>=3.11.*to>=3.14fre-nctoolsremoved as a package dependencyfregridusingshutil.which()and skip if not availablepython,pip,setuptools,wheelDocumentation Updates Needed
1. Update README.md
Add a new "Requirements" section after the "Intro" section and before "Quickstart" to document:
>= 3.11(currently tested on Python 3.12)>= 3.14fre-nctoolsno longer being a package dependencyThe new section should be added around line 30, formatted as:
Or install separately:
SKIPPED [1] fre/app/regrid_xy/tests/test_regrid_xy.py:85: fregrid not in env. it was removed from package reqs. you must load it externally
Key Dependency Versions
requires
fre-nctoolsandfregridto be in one'sPATHvariable, andpython3(tested/developed with python 3.9.16). there should benetCDF4andmetomipython modules in one's python environment for imports.pytestandnccmpis required for tests.pylintrecommended for future developers working on this tool.If not available, on GFDL/Gaea systems:
Or install separately:
Python Requirements
netCDF4python modulexarraypython modulepytestandnccmpfor running testspylintrecommended for developersNote: Without
fregridin your PATH, regrid_xy operations will fail, and related tests will be automatically skipped.