Skip to content

Conversation

@nishu-builder
Copy link
Contributor

@nishu-builder nishu-builder commented Jan 17, 2026

Summary

  • Updated sql_routes.py to use db_session() and text() instead of MettaRepo
  • Removed MettaRepo dependency from server.py entirely
  • create_app() no longer requires any parameters

This completes the migration of app_backend from raw SQL to SQLAlchemy. The MettaRepo class now only contains connection pool infrastructure and migration code - all domain query methods have been moved to the new queries/ modules.

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • add-to-merge-queue - adds this PR to the back of the merge queue
  • add-to-merge-queue-as-hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@datadog-official
Copy link

datadog-official bot commented Jan 17, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 6 Tests failed

    test_recipe_discovery_without_init from test_recipe_discovery.py (Fix with Cursor)

    test_recipe_registry_get_normalizes_paths from test_recipe_discovery.py (Fix with Cursor)

    test_recipe_short_name from test_recipe_discovery.py (Fix with Cursor)

View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3dceab2 | Docs | Was this helpful? Give us feedback!

@blacksmith-sh

This comment has been minimized.

@nishu-builder nishu-builder force-pushed the nishad/sqlalchemy-sql-routes branch from 059e144 to 3dceab2 Compare January 19, 2026 04:49
@nishu-builder nishu-builder force-pushed the nishad/sqlalchemy-sweeps branch from 23ca2c1 to 016d411 Compare January 19, 2026 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants