Migrate episode queries to SQLAlchemy #4973
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
nishu-builder
force-pushed
the
nishad/sqlalchemy-episodes
branch
from
a4f9c98 to
5fe8ccc
Compare
graphite-app
bot
force-pushed
the
nishad/sqlalchemy-migration
branch
from
24f1d7d to
19c4a42
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a4f9c98716
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await session.flush() | ||
| return id |
There was a problem hiding this comment.
record_episode only calls flush() and returns; with_db/db_session() never commits, so the AsyncSession will roll back when the context exits. This means bulk uploads and episode inserts appear to succeed but nothing is persisted unless the caller commits (the stats route doesn’t). Add an explicit await session.commit() (or wrap in a transaction that commits) before returning to avoid losing writes.
Useful? React with 👍 / 👎.
graphite-app
bot
force-pushed
the
nishad/sqlalchemy-migration
branch
from
19c4a42 to
afc9c59
Compare
graphite-app
bot
force-pushed
the
nishad/sqlalchemy-episodes
branch
from
5fe8ccc to
2348b66
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nishu-builder
force-pushed
the
nishad/sqlalchemy-migration
branch
from
afc9c59 to
9d4cd17
Compare
nishu-builder
force-pushed
the
nishad/sqlalchemy-episodes
branch
from
2348b66 to
85cbe40
Compare
- Update Episode model with missing fields (data_uri, primary_pv_id, thumbnail_url, eval_task_id) - Add EpisodeTag model - Create queries/episode_queries.py with record_episode and get_episodes - Update stats_routes.py to use new episode queries - Move EpisodeWithTags model to episode_queries.py Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
nishu-builder
force-pushed
the
nishad/sqlalchemy-migration
branch
from
9d4cd17 to
fa7f5de
Compare
nishu-builder
force-pushed
the
nishad/sqlalchemy-episodes
branch
from
85cbe40 to
0efd8de
Compare
Summary
models/episodes.pywith Episode and EpisodeTag SQLModel modelsqueries/episode_queries.pywith SQLAlchemy query functionsroutes/stats_routes.pyto use the new query moduleEpisodeReplay,EpisodeWithTags,record_episode,get_episodes)Part of stack to migrate app_backend from raw SQL to SQLAlchemy.