Migrate eval_task queries to SQLAlchemy #4974
Draft
+457
−425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This comment has been minimized.
This comment has been minimized.
nishu-builder
force-pushed
the
nishad/sqlalchemy-eval-tasks
branch
from
83232de to
d5f019b
Compare
nishu-builder
force-pushed
the
nishad/sqlalchemy-episodes
branch
from
85cbe40 to
0efd8de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
models/eval_task.pywith EvalTask and TaskAttempt SQLModel modelsqueries/eval_task_queries.pywith SQLAlchemy query functionsroutes/eval_task_routes.pyto use the new query moduleTaskStatus,FinishedTaskStatus,TaskStatusUpdate,EvalTaskRow,TaskAttemptRow, and all eval_task methods)Uses
text()queries for complex view-based queries (eval_tasks_view) since the view-based approach is more maintainable than pure SQLAlchemy for this schema.Part of stack to migrate app_backend from raw SQL to SQLAlchemy.