-
Notifications
You must be signed in to change notification settings - Fork 47
test: mint and burn #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
test: mint and burn #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rflechtner
commented
Nov 20, 2024
rflechtner
commented
Nov 20, 2024
rflechtner
commented
Nov 20, 2024
Ad96el
reviewed
Nov 21, 2024
pallets/pallet-bonded-coins/src/tests/transactions/mint_into.rs
Outdated
Show resolved
Hide resolved
pallets/pallet-bonded-coins/src/tests/transactions/mint_into.rs
Outdated
Show resolved
Hide resolved
pallets/pallet-bonded-coins/src/tests/transactions/mint_into.rs
Outdated
Show resolved
Hide resolved
This reverts commit 1529674.
Ad96el
approved these changes
Nov 25, 2024
Contributor
Ad96el
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re/ KILTProtocol/ticket#3671
Adds unit tests for burning and minting. Tests document EXPECTED behaviour, which currently differs from the actual behaviour in a lot of places.
Currently failing:
mint_into::mint_first_coin
assert_eq_error_rate!with error1.mint_into::mint_in_refunding_pool
PoolNotLiveerror but yieldsNoPermissionmint_into::mint_large_quantity
mint_into::multiple_mints_vs_combined_mint
burn_into::burn_in_refunding_pool
PoolNotLiveerror but yieldsNoPermissionburn_into::burn_large_quantity
burn_into::multiple_burns_vs_combined_burn
just like multiple vs single mint fails due to imprecision - not clear if this can be resolved
burn_into::multiple_mints_vs_combined_burn
FundsUnavailable. Must be fixed by improving rounding!burn_into::burn_with_frozen_balance
burn_into::burn_to_other
Checklist:
array[3]useget(3), ...)