test: destroy #804
Merged
test: destroy #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ad96el
reviewed
Nov 22, 2024
Contributor
Ad96el
left a comment
Ad96el
left a comment
There was a problem hiding this comment.
LGTM. One style suggestion.
pallets/pallet-bonded-coins/src/tests/transactions/finish_destroy.rs
Outdated
Show resolved
Hide resolved
|
|
||
| // Verify that the pool state has been updated to destroying | ||
| let updated_pool = Pools::<Test>::get(&pool_id).unwrap(); | ||
| assert!(matches!(updated_pool.state, PoolStatus::Destroying)); |
Contributor
There was a problem hiding this comment.
assert_eq! would look simpler. Same for the others further below
Base automatically changed from
rf-test-mint-and-burn
to
pallet_bonded_coins
November 25, 2024 12:31
rflechtner
force-pushed
the
rf-test-destroy
branch
from
5c56ce7 to
ccf6912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re/ https://github.com/KILTprotocol/ticket/issues/3671
Tests the three destruction extrinsics. All tests passing rn.
To be rebased after merging #791.
Checklist:
array[3]useget(3), ...)