Skip to content

test: lock/unlock #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rflechtner merged 2 commits into from
Nov 25, 2024
Merged

test: lock/unlock #806

rflechtner merged 2 commits into from
Nov 25, 2024

Conversation

@rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Nov 21, 2024 •
edited
Loading

re/ https://github.com/KILTprotocol/ticket/issues/3671

Implements unit tests for set_lock & unlock.

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@rflechtner rflechtner changed the base branch from develop to pallet_bonded_coins November 21, 2024 14:44
@rflechtner rflechtner changed the title Test lock unlock test: lock/unlock Nov 21, 2024
@rflechtner rflechtner marked this pull request as ready for review November 21, 2024 14:46
@rflechtner rflechtner requested a review from Ad96el November 21, 2024 14:46
@rflechtner rflechtner changed the base branch from pallet_bonded_coins to rf-test-mint-and-burn November 21, 2024 17:54
Base automatically changed from rf-test-mint-and-burn to pallet_bonded_coins November 25, 2024 12:31
@rflechtner rflechtner merged commit d76256a into pallet_bonded_coins Nov 25, 2024
7 of 12 checks passed
@rflechtner rflechtner deleted the test-lock-unlock branch November 25, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Ad96el Ad96el Ad96el approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rflechtner @Ad96el