Skip to content

Implement tileHashes pattern in OctreeTiler to match QuadtreeTiler #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 4 commits into from
Closed

Implement tileHashes pattern in OctreeTiler to match QuadtreeTiler #249

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76d4d4d
Initial plan
Copilot Feb 5, 2026
57e0744
Remove unused tileHashes variable from OctreeTiler
Copilot Feb 5, 2026
d013a3f
Implement tileHashes pattern like QuadtreeTiler
Copilot Feb 5, 2026
f3470e3
Only call UpdateTileBoundingBox3D when not using implicit tiling
Copilot Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 32 additions & 2 deletions src/b3dm.tileset/OctreeTiler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,20 +114,28 @@ private HashSet<string> CreateTileForLargestGeometries3D(BoundingBox3D bbox, int

var file = $"{tilesetSettings.OutputSettings.ContentFolder}{Path.AltDirectorySeparatorChar}{tile.Level}_{tile.Z}_{tile.X}_{tile.Y}.glb";
TileCreationHelper.WriteTileIfNeeded(geometriesToProcess, tilesetSettings.Translation, stylingSettings, tilesetSettings.Copyright, tilingSettings.CreateGltf, tilingSettings.SkipCreateTiles, file, file);

if (!tilingSettings.UseImplicitTiling) {
UpdateTileBoundingBox3D(tile, tileBounds, tileHashes, where);
}

tile.Available = true;
}

tiles.Add(tile);
if (tileBounds != null) {
var key = $"{tile.Level}_{tile.Z}_{tile.X}_{tile.Y}";
tileBounds[key] = bbox;
if (!tileBounds.ContainsKey(key)) {
tileBounds[key] = bbox;
}
}

return localProcessedGeometries;
}

private void CreateTile3D(BoundingBox3D bbox, int level, Tile3D tile, List<Tile3D> tiles, Dictionary<string, BoundingBox3D> tileBounds, string where, HashSet<string> processedGeometries)
{
var tileHashes = new HashSet<string>();
int target_srs = tilingSettings.KeepProjection ? inputTable.EPSGCode : 4978;

var bbox1 = new double[] { bbox.XMin, bbox.YMin, bbox.XMax, bbox.YMax, bbox.ZMin, bbox.ZMax };
Expand All @@ -136,11 +144,17 @@ private void CreateTile3D(BoundingBox3D bbox, int level, Tile3D tile, List<Tile3
if (geometries.Count > 0) {
// Collect hashes of processed geometries
foreach (var geom in geometries.Where(geom => !string.IsNullOrEmpty(geom.Hash))) {
tileHashes.Add(geom.Hash);
processedGeometries.Add(geom.Hash);
}

var file = $"{tilesetSettings.OutputSettings.ContentFolder}{Path.AltDirectorySeparatorChar}{tile.Level}_{tile.Z}_{tile.X}_{tile.Y}.glb";
TileCreationHelper.WriteTileIfNeeded(geometries, tilesetSettings.Translation, stylingSettings, tilesetSettings.Copyright, tilingSettings.CreateGltf, tilingSettings.SkipCreateTiles, file, file);

if (!tilingSettings.UseImplicitTiling) {
UpdateTileBoundingBox3D(tile, tileBounds, tileHashes, where);
}

tile.Available = true;
}
else {
Expand All @@ -150,7 +164,23 @@ private void CreateTile3D(BoundingBox3D bbox, int level, Tile3D tile, List<Tile3
tiles.Add(tile);
if (tileBounds != null) {
var key = $"{tile.Level}_{tile.Z}_{tile.X}_{tile.Y}";
tileBounds[key] = bbox;
if (!tileBounds.ContainsKey(key)) {
tileBounds[key] = bbox;
}
}
}

private void UpdateTileBoundingBox3D(Tile3D tile, Dictionary<string, BoundingBox3D> tileBounds, HashSet<string> tileHashes, string where)
{
if (tileBounds == null || tileHashes.Count == 0) {
return;
}

// Update bounding box based on actual geometries in the tile
var bbox_geometries = GeometryRepository.GetGeometriesBoundingBox(conn, inputTable.TableName, inputTable.GeometryColumn, inputTable.EPSGCode, null, tileHashes, where, tilingSettings.KeepProjection);
var bbox3d = new BoundingBox3D(bbox_geometries[0], bbox_geometries[1], bbox_geometries[4], bbox_geometries[2], bbox_geometries[3], bbox_geometries[5]);

var key = $"{tile.Level}_{tile.Z}_{tile.X}_{tile.Y}";
tileBounds[key] = bbox3d;
}
}
Loading