Implement tileHashes pattern in OctreeTiler to match QuadtreeTiler#249
Closed
Copilot wants to merge 4 commits intomd5_implementationfrom
Closed
Implement tileHashes pattern in OctreeTiler to match QuadtreeTiler#249Copilot wants to merge 4 commits intomd5_implementationfrom
Copilot wants to merge 4 commits intomd5_implementationfrom
Conversation
Co-authored-by: bertt <538812+bertt@users.noreply.github.com>
Member
|
@copilot implement like the quadtreetiler does it |
Copilot
AI
changed the title
[WIP] Address feedback on size-based geometry prioritization
Remove unused tileHashes variable from OctreeTiler
Feb 5, 2026
Co-authored-by: bertt <538812+bertt@users.noreply.github.com>
Contributor
Author
Implemented in commit d013a3f. The OctreeTiler now follows the same pattern as QuadtreeTiler:
|
Copilot
AI
changed the title
Remove unused tileHashes variable from OctreeTiler
Implement tileHashes pattern in OctreeTiler to match QuadtreeTiler
Feb 5, 2026
Member
|
@copilot only call updateTileBox when not useImplicitTiling |
Co-authored-by: bertt <538812+bertt@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the same tileHashes pattern used in QuadtreeTiler for OctreeTiler to accurately track and update tile bounding boxes based on actual geometry extents.
Changes
tileHashesHashSet in bothCreateTileForLargestGeometries3DandCreateTile3Dto track which geometries are placed in each specific tileUpdateTileBoundingBox3Dmethod that recalculates tile bounding boxes based on actual geometry extents usingGeometryRepository.GetGeometriesBoundingBoxtileBoundsdictionary entries to reflect accurate 3D bounding boxes of the geometries in each tileUpdateTileBoundingBox3Dwhen!tilingSettings.UseImplicitTiling, matching the QuadtreeTiler optimization patternThis is important for handling geometries where the centroid is in one tile but the geometry extends into neighboring areas. The accurate bounding boxes ensure correct rendering and spatial queries, matching the behavior already present in QuadtreeTiler. The conditional update avoids unnecessary database queries when implicit tiling is enabled.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.