Refactor run_conversion to be embodiment agnostic#259
Open
ElmoPA wants to merge 1 commit intoelmo/refactor-aria-procfrom
Open
Refactor run_conversion to be embodiment agnostic#259ElmoPA wants to merge 1 commit intoelmo/refactor-aria-procfrom
ElmoPA wants to merge 1 commit intoelmo/refactor-aria-procfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ryanthecreator
force-pushed
the
elmo/run-conversion
branch
2 times, most recently
from
814108a to
f200495
Compare
ryanthecreator
force-pushed
the
elmo/refactor-aria-proc
branch
from
3326ff0 to
0043aba
Compare
ryanthecreator
force-pushed
the
elmo/run-conversion
branch
2 times, most recently
from
76f27cb to
51586b6
Compare
ryanthecreator
force-pushed
the
elmo/refactor-aria-proc
branch
from
6a587fd to
4a7ea84
Compare
ryanthecreator
force-pushed
the
elmo/run-conversion
branch
from
51586b6 to
b1bf83b
Compare
ryanthecreator
force-pushed
the
elmo/refactor-aria-proc
branch
from
4a7ea84 to
8643c2f
Compare
ryanthecreator
force-pushed
the
elmo/run-conversion
branch
from
b1bf83b to
2c0507f
Compare
ryanthecreator
force-pushed
the
elmo/refactor-aria-proc
branch
2 times, most recently
from
66493b8 to
2af09c6
Compare
ryanthecreator
force-pushed
the
elmo/run-conversion
branch
2 times, most recently
from
259e537 to
e0c8a8a
Compare
ryanthecreator
force-pushed
the
elmo/refactor-aria-proc
branch
from
2af09c6 to
e01ca2f
Compare
SimarKareer
requested changes
Mar 8, 2026
| "PROCESSED_REMOTE_PREFIX", "s3://rldb/processed_v3/test_aria" | ||
| ).rstrip("/") | ||
| self.bucket = os.environ.get("BUCKET", "rldb") | ||
| self.resources_small = {"eva_small": 1} # TODO: change to aria_small |
Collaborator
There was a problem hiding this comment.
Should this be aria_small and aria_big?
Contributor
There was a problem hiding this comment.
Yes I forgot to change it back after testing. Thx for spotting that out.
| arm = infer_arm_from_row(row) | ||
| task_name = infer_task_name_from_row(row) | ||
| task_description = infer_task_description_from_row(row) | ||
| # TODO: add dry run, right now the script does not work with this dry run code |
Collaborator
There was a problem hiding this comment.
Dry run is pretty important, can you add back?
ryanthecreator
force-pushed
the
elmo/run-conversion
branch
from
e0c8a8a to
4b9d128
Compare
ryanthecreator
force-pushed
the
elmo/refactor-aria-proc
branch
from
e01ca2f to
03d4e6d
Compare
ryanthecreator
force-pushed
the
elmo/run-conversion
branch
from
4b9d128 to
f7a068d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.