Skip to content

Refactor aria changes#257

Open
ElmoPA wants to merge 1 commit intoelmo/refactor-eva-procfrom
elmo/refactor-aria-proc
Open

Refactor aria changes#257
ElmoPA wants to merge 1 commit intoelmo/refactor-eva-procfrom
elmo/refactor-aria-proc

Conversation

@ElmoPA
Copy link
Contributor

@ElmoPA ElmoPA commented Mar 4, 2026

No description provided.

@ElmoPA ElmoPA marked this pull request as ready for review March 4, 2026 23:29
Copy link
Contributor Author

ElmoPA commented Mar 4, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

transformed_x_axis = (transform @ x_axis_h)[:3]
transformed_y_axis = (transform @ y_axis_h)[:3]
transformed_z_axis = (transform @ z_axis_h)[:3]
def timestamp_ms_to_episode_hash(timestamp_ms: int) -> str:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file already exists in aws_sql.py

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove this I forgot to remove it

return out


def quat_translation_swap(quat_translation: np.ndarray) -> np.ndarray:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put in pose_utils.py?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can I guess. My first reasoning was that this is pretty specific to this file probably. I think its also fine to put it in pose_utils.py

@ryanthecreator ryanthecreator force-pushed the elmo/refactor-aria-proc branch from 3326ff0 to 0043aba Compare March 5, 2026 06:05
@ryanthecreator ryanthecreator force-pushed the elmo/refactor-eva-proc branch from d656b71 to 23a8385 Compare March 5, 2026 06:05
@ryanthecreator ryanthecreator force-pushed the elmo/refactor-aria-proc branch from 0043aba to 6a587fd Compare March 5, 2026 06:17
@ryanthecreator ryanthecreator force-pushed the elmo/refactor-eva-proc branch from 23a8385 to aeb8955 Compare March 5, 2026 23:08
@ryanthecreator ryanthecreator force-pushed the elmo/refactor-aria-proc branch 5 times, most recently from 2af09c6 to e01ca2f Compare March 8, 2026 03:51
@ryanthecreator ryanthecreator force-pushed the elmo/refactor-eva-proc branch from aeb8955 to b7d2cf6 Compare March 8, 2026 03:51

N, C, H, W = images.shape

if H == 480:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to break with your Aria high res?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use this function

T_device_rgb_camera = rgb_camera_calibration.get_transform_device_camera()
T_world_rgb_camera = (T_world_device @ T_device_rgb_camera).to_matrix()
return T_world_rgb_camera
STEP_DEFAULT = 3.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't being used except CHUNK_LENGTH_ACT

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok will remove this

mps_sample_path, "slam", "closed_loop_trajectory.csv"
)

eye_gaze_path = os.path.join(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we test eye gaze?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It processed and shows up. Just we dont have viz. Might wanna ask fiona for one.

Copy link
Collaborator

@SimarKareer SimarKareer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@ryanthecreator ryanthecreator force-pushed the elmo/refactor-eva-proc branch from b7d2cf6 to 4e6faae Compare March 8, 2026 22:22
@ryanthecreator ryanthecreator force-pushed the elmo/refactor-aria-proc branch from e01ca2f to 03d4e6d Compare March 8, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants