Test infrastructure definiton #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2025
Merged
Szelethus
reviewed
Aug 15, 2025
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
Can we move setup_logging here as well?
Szelethus
reviewed
Aug 15, 2025
Contributor
Author
|
We are learning by trial; this patch is not ready yet. |
nettle
reviewed
Aug 17, 2025
nettle
reviewed
Aug 17, 2025
Szelethus
reviewed
Aug 18, 2025
Szelethus
reviewed
Aug 18, 2025
Szelethus
reviewed
Aug 18, 2025
furtib
force-pushed
the
common_lib_for_unit_tests
branch
from
8bb540d to
2794f4f
Compare
Szelethus
reviewed
Aug 19, 2025
Szelethus
reviewed
Aug 19, 2025
Szelethus
changed the title
Szelethus
changed the title
Szelethus
reviewed
Aug 19, 2025
This is necessary to let other packages in this folder use the common library
furtib
force-pushed
the
common_lib_for_unit_tests
branch
from
45d1c13 to
217dc53
Compare
Szelethus
approved these changes
Aug 19, 2025
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
It took a while, thank you so much for the patience! LGTM! I'm sure we'll find some issues later down the line as we put this base class to the test (haha), but lets move on now.
Szelethus
reviewed
Aug 21, 2025
Szelethus
reviewed
Aug 21, 2025
furtib
added a commit
to furtib/codechecker_bazel
that referenced
this pull request
Aug 27, 2025
Why: We have no rigid guidelines or utilities for our testing needs. What: - Created a README.md detailing how to run and extend our test suite. - Created a common library to provide utility for new tests. - The common lib contains the TestBase class with a few modifications: - The check_command has been renamed to run_command; it no longer asserts anything, it returns the exit code, and the stdout and stderr in a tuple - The global variables for the BAZEL_BIN_DIR and BAZEL_TESTLOGS_DIR have been moved into the class as data. They must be set by the test class. - A new variable \_\_test_path\_\_ have been introduced; this is necessary so execution always happens in the specific tests directory. - Added a template test, so new tests can be started with just a `cp -r template/ new_test/` Addresses: Ericsson#22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
We have no rigid guidelines or utilities for our testing needs.
What:
cp -r template/ new_test/Addresses:
#22