Skip to content

Unit test: caching #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Szelethus merged 32 commits into from
Aug 29, 2025
Merged

Unit test: caching #59

Szelethus merged 32 commits into from
Aug 29, 2025

Conversation

@furtib
Copy link
Contributor

@furtib furtib commented Aug 13, 2025 •
edited
Loading

Why: We should have a unit test for caching! (for #24 and #23)

What:
Created a test case that:

  • Analyzes a two-source file target
  • Edits one file from the two
  • Reruns the analysis, counts the number of files analyzed, with the subcommands option

Scope:

  • Limited: One acceptance is likely sufficient before merging.

Dpends on: #60

Addresses:

@furtib furtib self-assigned this Aug 13, 2025
@furtib
Copy link
Contributor Author

furtib commented Aug 15, 2025

Depends on #61

@furtib furtib force-pushed the test_caching branch 6 times, most recently from 989e988 to 339da35 Compare August 18, 2025 07:28
@furtib furtib requested review from Szelethus and Copilot August 18, 2025 08:20

This comment was marked as spam.

Sign in to view

Szelethus
Szelethus requested changes Aug 25, 2025
View reviewed changes
@furtib furtib requested a review from Szelethus August 25, 2025 08:35
Szelethus
Szelethus requested changes Aug 25, 2025
View reviewed changes
@furtib furtib requested a review from Szelethus August 25, 2025 10:34
Szelethus
Szelethus reviewed Aug 25, 2025
View reviewed changes
Szelethus
Szelethus reviewed Aug 25, 2025
View reviewed changes
@Szelethus Szelethus added the test ☑️ Adding or refactoring tests label Aug 25, 2025
@furtib furtib requested a review from Szelethus August 25, 2025 10:56
Szelethus
Szelethus reviewed Aug 25, 2025
View reviewed changes
Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that ctu is a pain point, we should add a testcase for it as well.

Szelethus
Szelethus reviewed Aug 26, 2025
View reviewed changes
@furtib furtib requested a review from Szelethus August 29, 2025 07:09
furtib and others added 25 commits August 29, 2025 09:32
@furtib
Add comments
b06bbc3
@furtib
Update for common lib
7e01520
@furtib
Update for working path
8ec5f4d
@furtib
Change to new path fix
0e01b02
@furtib
Format
be93405
@furtib
Update comment
c4411be
@furtib
Add license
15f2b42
@furtib
Update to follow common lib
0b4607d
@furtib
Remove comments
65bb6aa
@furtib
Add setUp and teardown to handle file changes
dd014f8
@furtib
Improve regex
fccaec3
@furtib
Replace regex
bca3cd7
@furtib
Change cleanup placement
a8dc75c
@furtib @Szelethus
Update test/unit/caching/test_caching.py
50f54ad 
Co-authored-by: Kristóf Umann <dkszelethus@gmail.com>
@furtib
Use python specific solutions where applicable
76cff4f
@furtib
Use only stderr
4c5344e
@furtib @Szelethus
Accept suggestion on test/unit/caching/test_caching.py
8405a5e 
Co-authored-by: Kristóf Umann <dkszelethus@gmail.com>
@furtib
Format
b9065ba
@furtib
Remove unnecesary variable
65633a8
@furtib
Add test for CTU targets caching
42a6ce2
@furtib
Fix name, add comments
66387de
@furtib
Add manual tag
bf0adb1
@furtib
Remove bug from source
66dbd59
@furtib
Remove unnecesary comments and tags
75082b5
@furtib
Add comment
413ccc7
Szelethus
Szelethus reviewed Aug 29, 2025
View reviewed changes
Szelethus
Szelethus approved these changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Szelethus Szelethus merged commit d6fc7f0 into Ericsson:main Aug 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Szelethus Szelethus Szelethus approved these changes

Assignees

@furtib furtib

Labels

test ☑️ Adding or refactoring tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@furtib @Szelethus