Skip to content

Conversation

@furtib
Copy link
Contributor

@furtib furtib commented Jul 25, 2025

Test for #14

The problem was that paths in plist files didn't get resolved when there was an error in a header file.

To reproduce the bug, I had to:

  • Add a header file that contains an error
  • Add a source file that includes said header
  • Add a rule for the new source fileí

Depends on: #60

@nettle
Copy link
Collaborator

nettle commented Jul 25, 2025

I think we should not submit this until we agree on #22

@Szelethus Szelethus requested review from Szelethus and nettle July 28, 2025 14:43
@furtib furtib self-assigned this Aug 11, 2025
@furtib
Copy link
Contributor Author

furtib commented Aug 12, 2025

Updated in accordance with #22, since this is a test for #14 it's expected to fail!

Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think its wise to copy-paste so much from each test file to the next (grep_file(), TestBase etc), we should think on this a little more. Sorry for being such a bore, we'll figure this out and we'll happily ride onto the sunset :)

Otherwise, the main idea behind this solution (directory structure, the test itself) looks great. Its just the boring stuff.

edit: some ideas here: #22 (comment)

@furtib
Copy link
Contributor Author

furtib commented Aug 15, 2025

I tried your approach, about the common lib, should that be its own PR? Or should we just leave it here, and then every other test will depend on this one?

@furtib
Copy link
Contributor Author

furtib commented Aug 15, 2025

Depends on #61

Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tidy this up with some python formatter? Otherwise, the direction is right.

@furtib furtib force-pushed the test_plist branch 5 times, most recently from 1c14e7e to 2ef29fc Compare August 18, 2025 07:28
@furtib furtib requested a review from Szelethus August 18, 2025 08:19
@furtib furtib force-pushed the test_plist branch 4 times, most recently from 029729e to 2c264c7 Compare August 19, 2025 13:27
Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use some formatter to make the code uniform and <80 cols. Otherwise LGTM

Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done @furtib. This was a lot of work, and I think it shows. Lets keep our eyes open if we need to adjust on the testing infrastructure, but for now, this looks pretty solid.

@Szelethus Szelethus merged commit ac91016 into Ericsson:main Aug 21, 2025
2 checks passed
furtib added a commit to furtib/codechecker_bazel that referenced this pull request Aug 27, 2025
Test for Ericsson#14 

The problem was that paths in plist files didn't get resolved when there
was an error in a header file.

To reproduce the bug, I had to:
- Add a header file that contains an error
- Add a source file that includes said header
- Add a rule for the new source fileí

Depends on: Ericsson#60

---------

Co-authored-by: Kristóf Umann <dkszelethus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants