-
Notifications
You must be signed in to change notification settings - Fork 3
Add test for symlink resolution #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think we should not submit this until we agree on #22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think its wise to copy-paste so much from each test file to the next (grep_file(), TestBase etc), we should think on this a little more. Sorry for being such a bore, we'll figure this out and we'll happily ride onto the sunset :)
Otherwise, the main idea behind this solution (directory structure, the test itself) looks great. Its just the boring stuff.
edit: some ideas here: #22 (comment)
|
I tried your approach, about the common lib, should that be its own PR? Or should we just leave it here, and then every other test will depend on this one? |
|
Depends on #61 |
Szelethus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you tidy this up with some python formatter? Otherwise, the direction is right.
1c14e7e to
2ef29fc
Compare
029729e to
2c264c7
Compare
Co-authored-by: Kristóf Umann <dkszelethus@gmail.com>
Szelethus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use some formatter to make the code uniform and <80 cols. Otherwise LGTM
Szelethus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very well done @furtib. This was a lot of work, and I think it shows. Lets keep our eyes open if we need to adjust on the testing infrastructure, but for now, this looks pretty solid.
Test for Ericsson#14 The problem was that paths in plist files didn't get resolved when there was an error in a header file. To reproduce the bug, I had to: - Add a header file that contains an error - Add a source file that includes said header - Add a rule for the new source fileí Depends on: Ericsson#60 --------- Co-authored-by: Kristóf Umann <dkszelethus@gmail.com>
Test for #14
The problem was that paths in plist files didn't get resolved when there was an error in a header file.
To reproduce the bug, I had to:
Depends on: #60