-
Notifications
You must be signed in to change notification settings - Fork 3
Add support for config files in per_file rule #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b2d3e4d to
e43237b
Compare
|
You can leave out the platform attribute by removing these lines (see above) |
Szelethus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a change of heart wrt this patch. I think we should absolutely add a query to CodeChecker we don't need to sort out how its configured, but for now, this is an acceptable fix and a small part of the patch.
Szelethus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch is now much simpler. Nice! Please create an issue for our poor ctu detection before merging.
Co-authored-by: F.Tibor <tibi.furesz@gmail.com>
62e5647 to
d25337b
Compare
|
We should know that during analysis phase, we cannot read from files (e.g. see if CTU is enabled in a config file), and also we cannot query other programs (e.g. CodeChecker cmd query-feature ctu) |
Why:
We want to support config files inside the
per_filerule, too.What:
Added the config rule to the
per_filerule, based on the codechecker_test rule.Addresses:
#30