Skip to content

Conversation

@furtib
Copy link
Contributor

@furtib furtib commented Dec 1, 2025

Why:
We want to support config files inside the per_file rule, too.

What:
Added the config rule to the per_file rule, based on the codechecker_test rule.

Addresses:
#30

@furtib furtib requested a review from Szelethus December 1, 2025 12:44
@furtib furtib self-assigned this Dec 1, 2025
@furtib furtib force-pushed the add-config-to-per-file branch 2 times, most recently from b2d3e4d to e43237b Compare December 2, 2025 13:36
@furtib
Copy link
Contributor Author

furtib commented Dec 2, 2025

You can leave out the platform attribute by removing these lines (see above)
I think these are necessary to support cross-platform analysis (?) (is there even such a thing?)

@furtib furtib mentioned this pull request Jan 9, 2026
Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a change of heart wrt this patch. I think we should absolutely add a query to CodeChecker we don't need to sort out how its configured, but for now, this is an acceptable fix and a small part of the patch.

Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch is now much simpler. Nice! Please create an issue for our poor ctu detection before merging.

@furtib furtib force-pushed the add-config-to-per-file branch from 62e5647 to d25337b Compare January 12, 2026 10:40
@furtib
Copy link
Contributor Author

furtib commented Jan 12, 2026

We should know that during analysis phase, we cannot read from files (e.g. see if CTU is enabled in a config file), and also we cannot query other programs (e.g. CodeChecker cmd query-feature ctu)
We may have to put a restriction on the use of the CTU flag in the config file.

@Szelethus Szelethus merged commit 73d81fc into Ericsson:main Jan 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants