-
Notifications
You must be signed in to change notification settings - Fork 3
Support bazel 7 #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bazel 7 #111
Conversation
|
We should test this somehow before merging. We should run unittests and FOSS on Bazel 7.7.0 too. |
I think all things considered, it is appropriate to add the tests in this PR. |
|
Sorry, that comment was a bit outdated. |
d9bc8e3 to
17c0a39
Compare
|
I had to comment out configs in the per_file part of the codechecker macro; this should not be necessary after #113 is merged |
d50ed67 to
4ea674c
Compare
Szelethus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I can't find a catch in here. The patch looks great!
dc1587b to
1fcc3b8
Compare
e3ce01f to
5e8949f
Compare
5e8949f to
2af90b8
Compare
Szelethus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, lets do it. Since the github CI changes land here at the same time, we can't really move the test changes to a separate PR, so this is as lean as this patch can get.
Why:
We want to extend our support for newer Bazel versions
What:
Added a variable
BAZEL_VERSIONto the generateddefs.bzlMade the attribute
_whitelist_function_transitionconditional. It is only added to the attributes list if the user uses a Bazel version older than 6.Addresses:
#108
Note:
The dictionary concatenation used may have been introduced in Bazel 6