Skip to content

Conversation

@furtib
Copy link
Contributor

@furtib furtib commented Dec 1, 2025

Why:
We want to extend our support for newer Bazel versions

What:
Added a variable BAZEL_VERSION to the generated defs.bzl
Made the attribute _whitelist_function_transition conditional. It is only added to the attributes list if the user uses a Bazel version older than 6.

Addresses:
#108

Note:
The dictionary concatenation used may have been introduced in Bazel 6

@furtib furtib requested a review from Szelethus December 1, 2025 10:36
@furtib furtib self-assigned this Dec 1, 2025
@furtib
Copy link
Contributor Author

furtib commented Dec 1, 2025

We should test this somehow before merging.

We should run unittests and FOSS on Bazel 7.7.0 too.
Should I make the necessary changes for that here or in a separate PR?

@furtib furtib marked this pull request as ready for review December 2, 2025 10:28
@furtib furtib added enhancement New feature or request non-functional change ☮️ The patch doesn't change any functionality, e.g. refactoring, documentation, test-only. labels Dec 2, 2025
@Szelethus
Copy link
Contributor

We should test this somehow before merging.

We should run unittests and FOSS on Bazel 7.7.0 too. Should I make the necessary changes for that here or in a separate PR?

I think all things considered, it is appropriate to add the tests in this PR.

@furtib
Copy link
Contributor Author

furtib commented Jan 7, 2026

Sorry, that comment was a bit outdated.
I have already started working on a more robust GitHub action suite so that it can be easily extended to multiple Bazel versions.
see #115

@furtib furtib force-pushed the support_bazel_7 branch 2 times, most recently from d9bc8e3 to 17c0a39 Compare January 9, 2026 07:29
@furtib
Copy link
Contributor Author

furtib commented Jan 9, 2026

I had to comment out configs in the per_file part of the codechecker macro; this should not be necessary after #113 is merged

@furtib furtib force-pushed the support_bazel_7 branch 2 times, most recently from d50ed67 to 4ea674c Compare January 9, 2026 21:52
Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I can't find a catch in here. The patch looks great!

Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, lets do it. Since the github CI changes land here at the same time, we can't really move the test changes to a separate PR, so this is as lean as this patch can get.

@Szelethus Szelethus merged commit 33206c6 into Ericsson:main Jan 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request non-functional change ☮️ The patch doesn't change any functionality, e.g. refactoring, documentation, test-only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants