Skip to content

Extend config handling to yaml files #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
furtib wants to merge 11 commits into from
Closed

Extend config handling to yaml files #102

furtib wants to merge 11 commits into from

Conversation

@furtib
Copy link
Contributor

@furtib furtib commented Nov 24, 2025 •
edited
Loading

Why:
We want to support not just JSON, but YAML config files too.

What:

  • Added support for YAML config files in the monolishic codechecker rule.
  • Added support for any config file in the per_file rule

Addresses:
Fixes #30
Depends on: #103

@furtib furtib requested a review from Szelethus November 24, 2025 13:34
@furtib furtib self-assigned this Nov 24, 2025
@furtib furtib added bug Something isn't working enhancement New feature or request labels Nov 24, 2025
@furtib
Copy link
Contributor Author

furtib commented Nov 24, 2025

I needed the separate file to deal with cyclic includions

@furtib furtib marked this pull request as ready for review November 24, 2025 16:08
@furtib furtib mentioned this pull request Nov 24, 2025
Merged
@Szelethus Szelethus added the API change ⚠️ Breaks existing API label Nov 25, 2025
@Szelethus Szelethus requested a review from nettle November 25, 2025 10:19
@Szelethus
Copy link
Contributor

Szelethus commented Nov 25, 2025

@nettle This PR as it is changes the load path of codechecker_config. Is that a dealbreaker?

Szelethus
Szelethus requested changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate to do this to you, but can you split this PR up? How about this:

  • Move codechecker_config to its own .bzl file,
  • Add config support to per_file analysis
  • Add .yaml support

@furtib
Copy link
Contributor Author

furtib commented Nov 25, 2025

:'(

@furtib
Copy link
Contributor Author

furtib commented Dec 1, 2025

Superseeded by #113, #112 and #104

@furtib furtib closed this Dec 1, 2025
furtib added a commit that referenced this pull request Dec 2, 2025
@furtib
Create Test case for config files (#103)
2e2520d 
Why:
We want to support config files; we should test for them.
What:
- Test whether every rule that takes a config file as an argument acts
on the content of said config file

Addresses:
#30
Test for #102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Szelethus Szelethus Szelethus requested changes

@nettle nettle Awaiting requested review from nettle

Assignees

@furtib furtib

Labels

API change ⚠️ Breaks existing API bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for YAML CodeChecker config files

2 participants

@furtib @Szelethus