Skip to content

Conversation

@furtib
Copy link
Contributor

@furtib furtib commented Nov 24, 2025

Why:
We want to support config files; we should test for them.
What:

  • Test whether every rule that takes a config file as an argument acts on the content of said config file

Addresses:
#30
Test for #102

@furtib furtib requested a review from Szelethus November 24, 2025 17:05
@furtib furtib self-assigned this Nov 24, 2025
@furtib furtib added the test ☑️ Adding or refactoring tests label Nov 24, 2025
@furtib furtib force-pushed the test-config branch 2 times, most recently from 43dfb62 to d408c79 Compare November 24, 2025 17:36
Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch overall looks OK, but can you beef up the comments a bit? Something like this:

Set to true -> Set to true after fix; should've copied the input config file to bazel-bin
Set to 0 -> Set to 0 after fix; the config file should've explicitly disabled the division-by-zero checker, but the file is unrecognized by per-file analysis

Also, I'm not sure how important it is to check the first lines of the original/copied config files.

@furtib
Copy link
Contributor Author

furtib commented Dec 1, 2025

I'm pretty sure that I'm comparing the whole file contents, not just the first line.
https://docs.python.org/3/tutorial/inputoutput.html#:~:text=To%20read,returned
Although this part might not be so useful after all.

@furtib furtib requested a review from Szelethus December 1, 2025 14:38
Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I won't annoy you to death with my nits (we will delete them in a followup patch anyways), so I'll leave it to you how much you want to fancy them up. The nits were mainly meant as a general advice on how these comments would be ideal if you were to write a similar patch in the future.

@furtib furtib merged commit 2e2520d into Ericsson:main Dec 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test ☑️ Adding or refactoring tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants